You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/15 09:37:14 UTC
[GitHub] [airflow] potiuk opened a new pull request #16454: Remove class references in changelogs
potiuk opened a new pull request #16454:
URL: https://github.com/apache/airflow/pull/16454
PyPI does not handle class references in changelogs.
Since we want changelogs to be part of PyPI readmes,
we need to remove those.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16454: Remove class references in changelogs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16454:
URL: https://github.com/apache/airflow/pull/16454#issuecomment-861372285
> Does `twine check` not already do that? https://twine.readthedocs.io/en/latest/#twine-check
It does. but so far we run it as 'last' step already after the doc-change was merged and packages were prepared. But yeah, it could be running `twine check` as the step in CI/preparation process rather than `readme_renderer`, to be more complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16454: Remove class references in changelogs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16454:
URL: https://github.com/apache/airflow/pull/16454#issuecomment-861401024
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16454: Remove class references in changelogs
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16454:
URL: https://github.com/apache/airflow/pull/16454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16454: Remove class references in changelogs
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16454:
URL: https://github.com/apache/airflow/pull/16454#issuecomment-861367503
Does `twine check` not already do that? https://twine.readthedocs.io/en/latest/#twine-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16454: Remove class references in changelogs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16454:
URL: https://github.com/apache/airflow/pull/16454#issuecomment-861353220
BTW. Need to add `python -m readme_renderer README.rst` as part of the preparation step :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org