[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #12267: Performance fixes in proto readers

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on a change in pull request #12267:
URL: https://github.com/apache/druid/pull/12267#discussion_r809758821



##########
File path: extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufReader.java
##########
@@ -88,7 +89,7 @@
   {
     Map<String, Object> record;
 
-    if (flattenSpec == null) {
+    if (flattenSpec == null || JSONPathSpec.DEFAULT.equals(flattenSpec)) {

Review comment:
       is it okay for us to use this path if flattenSpec is set to 
   ```
   {
   useFieldDiscovery : true,
   fields : []
   }
   ```
   because that is what will happen here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org