You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/28 01:51:07 UTC
[GitHub] [apisix-go-plugin-runner] spacewander opened a new pull request #14: refactor: move internal/log to pkg/log
spacewander opened a new pull request #14:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #14: refactor: move internal/log to pkg/log
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #14:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/14#issuecomment-869276417
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7ffdf1) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/a6957f80be46361fce7d25a48dc88c448f1e3ff5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6957f8) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head d7ffdf1 differs from pull request most recent head 9372771. Consider uploading reports for the commit 9372771 to get more accurate results
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 81.31% 81.31%
=======================================
Files 9 9
Lines 487 487
=======================================
Hits 396 396
Misses 71 71
Partials 20 20
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/plugin/conf.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL2NvbmYuZ28=) | `90.69% <ø> (ø)` | |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `76.92% <ø> (ø)` | |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `77.67% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6957f8...9372771](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #14: refactor: move internal/log to pkg/log
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #14:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #14: refactor: move internal/log to pkg/log
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #14:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/14#issuecomment-869276417
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9521f55) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/a6957f80be46361fce7d25a48dc88c448f1e3ff5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6957f8) will **decrease** coverage by `2.46%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 9521f55 differs from pull request most recent head 82a84f9. Consider uploading reports for the commit 82a84f9 to get more accurate results
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
- Coverage 81.31% 78.85% -2.47%
==========================================
Files 9 9
Lines 487 487
==========================================
- Hits 396 384 -12
- Misses 71 82 +11
- Partials 20 21 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cmd/go-runner/main.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9tYWluLmdv) | `35.38% <0.00%> (ø)` | |
| [cmd/go-runner/plugins/say.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y21kL2dvLXJ1bm5lci9wbHVnaW5zL3NheS5nbw==) | `71.42% <0.00%> (ø)` | |
| [internal/plugin/conf.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL2NvbmYuZ28=) | `90.69% <ø> (ø)` | |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `76.92% <ø> (ø)` | |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `66.96% <ø> (-10.72%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6957f8...82a84f9](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/14?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org