You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by da...@apache.org on 2023/04/07 13:18:29 UTC
[doris] branch branch-1.2-lts updated: [config] modify tablet_shard to 4 and add some log (#18416) (#18482)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 62b20b126f [config] modify tablet_shard to 4 and add some log (#18416) (#18482)
62b20b126f is described below
commit 62b20b126ff94284b3b9b84a6c2e0e931c157565
Author: Luwei <81...@qq.com>
AuthorDate: Fri Apr 7 21:18:20 2023 +0800
[config] modify tablet_shard to 4 and add some log (#18416) (#18482)
modify the default value of BE config tablet_map_shard_size to 4. To reduce lock contention.
Add log when failed writing disk test file, for debug
Co-authored-by: Mingyu Chen <mo...@163.com>
---
be/src/common/config.h | 2 +-
be/src/olap/data_dir.cpp | 3 ++-
be/src/olap/tablet_manager.cpp | 2 +-
docs/en/docs/admin-manual/config/be-config.md | 2 +-
docs/zh-CN/docs/admin-manual/config/be-config.md | 2 +-
5 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 4bdc1dfebf..94cad91159 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -633,7 +633,7 @@ CONF_mInt64(max_runnings_transactions_per_txn_map, "100");
// tablet_map_lock shard size, the value is 2^n, n=0,1,2,3,4
// this is a an enhancement for better performance to manage tablet
-CONF_Int32(tablet_map_shard_size, "1");
+CONF_Int32(tablet_map_shard_size, "4");
// txn_map_lock shard size, the value is 2^n, n=0,1,2,3,4
// this is a an enhancement for better performance to manage txn
diff --git a/be/src/olap/data_dir.cpp b/be/src/olap/data_dir.cpp
index 7da8913843..10056b1917 100644
--- a/be/src/olap/data_dir.cpp
+++ b/be/src/olap/data_dir.cpp
@@ -235,7 +235,8 @@ void DataDir::health_check() {
if (_is_used) {
Status res = _read_and_write_test_file();
if (!res) {
- LOG(WARNING) << "store read/write test file occur IO Error. path=" << _path;
+ LOG(WARNING) << "store read/write test file occur IO Error. path=" << _path
+ << ", err: " << res;
if (res.is_io_error()) {
_is_used = false;
}
diff --git a/be/src/olap/tablet_manager.cpp b/be/src/olap/tablet_manager.cpp
index ec031eecd5..19fb4de676 100644
--- a/be/src/olap/tablet_manager.cpp
+++ b/be/src/olap/tablet_manager.cpp
@@ -1069,7 +1069,7 @@ void TabletManager::try_delete_unused_tablet_path(DataDir* data_dir, TTabletId t
TabletMetaSharedPtr tablet_meta(new TabletMeta());
Status check_st = TabletMetaManager::get_meta(data_dir, tablet_id, schema_hash, tablet_meta);
if (check_st.ok()) {
- LOG(INFO) << "tablet meta exist is meta store, skip delete the path " << schema_hash_path;
+ LOG(INFO) << "tablet meta exists in meta store, skip delete the path " << schema_hash_path;
return;
}
diff --git a/docs/en/docs/admin-manual/config/be-config.md b/docs/en/docs/admin-manual/config/be-config.md
index 6e5eda0d1a..aa76e418c4 100644
--- a/docs/en/docs/admin-manual/config/be-config.md
+++ b/docs/en/docs/admin-manual/config/be-config.md
@@ -1314,7 +1314,7 @@ Log printing module, writing olap will only print the log under the olap module
### `tablet_map_shard_size`
-Default: 1
+Default: 4
tablet_map_lock fragment size, the value is 2^n, n=0,1,2,3,4, this is for better tablet management
diff --git a/docs/zh-CN/docs/admin-manual/config/be-config.md b/docs/zh-CN/docs/admin-manual/config/be-config.md
index 40277d6a8e..50e71fbe77 100644
--- a/docs/zh-CN/docs/admin-manual/config/be-config.md
+++ b/docs/zh-CN/docs/admin-manual/config/be-config.md
@@ -1333,7 +1333,7 @@ TabletsChannel 的存活时间。如果此时通道没有收到任何数据，
### `tablet_map_shard_size`
-默认值：1
+默认值：4
tablet_map_lock 分片大小，值为 2^n, n=0,1,2,3,4 ，这是为了更好地管理tablet
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org