You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2019/02/06 19:59:03 UTC
[Impala-ASF-CR] IMPALA-8169: small changes to Leopard
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12386
Change subject: IMPALA-8169: small changes to Leopard
......................................................................
IMPALA-8169: small changes to Leopard
- Fix a bug in which rsync --chown doesn't work on CentOS 7.
- Update HOST_TESTDATA_EXTERNAL_VOLUME_PATH (for the minicluster data):
most runs now are on EC2 etc., and they already need a large volume
for docker images, so just keep the cluster data there, too.
- Reduce extremely verbose logging.
- Default to a database that's part of dataload (tpch_kudu).
- Change some of the controller variables to my preferred defaults.
Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Testing: Regular downstream runs for months.
---
M tests/comparison/leopard/controller.py
M tests/comparison/leopard/impala_docker_env.py
2 files changed, 10 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/12386/1
--
To view, visit http://gerrit.cloudera.org:8080/12386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
[Impala-ASF-CR] IMPALA-8169: small changes to Leopard
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12386 )
Change subject: IMPALA-8169: small changes to Leopard
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3730/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 21:40:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8169: small changes to Leopard
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12386 )
Change subject: IMPALA-8169: small changes to Leopard
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 21:38:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8169: small changes to Leopard
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12386 )
Change subject: IMPALA-8169: small changes to Leopard
......................................................................
IMPALA-8169: small changes to Leopard
- Fix a bug in which rsync --chown doesn't work on CentOS 7.
- Update HOST_TESTDATA_EXTERNAL_VOLUME_PATH (for the minicluster data):
most runs now are on EC2 etc., and they already need a large volume
for docker images, so just keep the cluster data there, too.
- Reduce extremely verbose logging.
- Default to a database that's part of dataload (tpch_kudu).
- Change some of the controller variables to my preferred defaults.
Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Testing: Regular downstream runs for months.
Reviewed-on: http://gerrit.cloudera.org:8080/12386
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/comparison/leopard/controller.py
M tests/comparison/leopard/impala_docker_env.py
2 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8169: small changes to Leopard
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12386 )
Change subject: IMPALA-8169: small changes to Leopard
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Feb 2019 01:48:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8169: small changes to Leopard
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12386 )
Change subject: IMPALA-8169: small changes to Leopard
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2003/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I169f60dad53d2e4980ed6bd1f350fb0dcf274306
Gerrit-Change-Number: 12386
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 20:33:07 +0000
Gerrit-HasComments: No