[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2647: ARTEMIS-2323 NettyTransport should also send requests with void promises

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2647: ARTEMIS-2323 NettyTransport should also send requests with void promises
URL: https://github.com/apache/activemq-artemis/pull/2647#discussion_r279147444
 
 

 ##########
 File path: tests/artemis-test-support/src/main/java/org/apache/activemq/transport/netty/NettyWSTransport.java
 ##########
 @@ -80,16 +80,13 @@ public NettyWSTransport(NettyTransportListener listener, URI remoteLocation, Net
    }
 
    @Override
-   public ChannelFuture send(ByteBuf output) throws IOException {
-      checkConnected();
-      int length = output.readableBytes();
-      if (length == 0) {
-         return null;
-      }
-
-      LOG.trace("Attempted write of: {} bytes", length);
 
 Review comment:
   Should keep trace logging in new methods for future debugging of issues in live systems

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services