You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2007/12/17 21:38:43 UTC

[jira] Assigned: (WICKET-1017) POSITIVE and NEGATIVE in NumberValidator are badly named (or contain a bug)

     [ https://issues.apache.org/jira/browse/WICKET-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-1017:
-------------------------------------

    Assignee: Johan Compagner

imho parameters should always be INCLUSIVE. so range (3,5) should accept 3,4,5. minumum(0) should accept 0,1,2,...

why do we even have POSITIVE and NEGATIVE? obviously it is rather ambiguous. lets deprecate those. i mean does it really save that much having them as global instances? they still get serialized the same...

> POSITIVE and NEGATIVE in NumberValidator are badly named (or contain a bug)
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-1017
>                 URL: https://issues.apache.org/jira/browse/WICKET-1017
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Sebastiaan van Erk
>            Assignee: Johan Compagner
>            Priority: Minor
>             Fix For: 1.3.0-rc3
>
>
> The POSITIVE validator is a new number validator with minimum 0.
> However 0 is not positive. Therefore, the validator should be called NONNEGATIVE. That or it should not allow 0.
> The validation messages (at least in Dutch) state that the number must be LARGER than 0 if I enter a negative number.
> However, 0 is of course accepted.
> Thus, for consistency I think it would probably be best to fix this one way or the other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.