You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@wandisco.com> on 2015/02/23 15:34:00 UTC
Re: svn commit: r1661671 - /subversion/trunk/subversion/libsvn_wc/wc_db.c
On 23.02.2015 14:47, rhuijben@apache.org wrote:
> Author: rhuijben
> Date: Mon Feb 23 13:47:00 2015
> New Revision: 1661671
>
> URL: http://svn.apache.org/r1661671
> Log:
> I did it again... I left an SVN_DBG() call :(
You've almost given me the motivation to write a pre-commit hook that
rejects the commit if it finds an SVN_DBG call in the code ... :)
-- Brane
Re: svn commit: r1661671 - /subversion/trunk/subversion/libsvn_wc/wc_db.c
Posted by Branko Čibej <br...@wandisco.com>.
On 23.02.2015 16:11, Philip Martin wrote:
> Branko Čibej <br...@wandisco.com> writes:
>
>> On 23.02.2015 14:47, rhuijben@apache.org wrote:
>>> Author: rhuijben
>>> Date: Mon Feb 23 13:47:00 2015
>>> New Revision: 1661671
>>>
>>> URL: http://svn.apache.org/r1661671
>>> Log:
>>> I did it again... I left an SVN_DBG() call :(
>> You've almost given me the motivation to write a pre-commit hook that
>> rejects the commit if it finds an SVN_DBG call in the code ... :)
> If we were to do that would we allow the use inside #if/ifdef? There
> are a few instances of that in the code.
I was kidding, right. You'd have to preprocess the code, which
essentially means you'd need a modified build environment just to check
for stray SVN_DBG instances. Not worth the effort.
-- Brane
Re: svn commit: r1661671 - /subversion/trunk/subversion/libsvn_wc/wc_db.c
Posted by Philip Martin <ph...@wandisco.com>.
Branko Čibej <br...@wandisco.com> writes:
> On 23.02.2015 14:47, rhuijben@apache.org wrote:
>> Author: rhuijben
>> Date: Mon Feb 23 13:47:00 2015
>> New Revision: 1661671
>>
>> URL: http://svn.apache.org/r1661671
>> Log:
>> I did it again... I left an SVN_DBG() call :(
>
> You've almost given me the motivation to write a pre-commit hook that
> rejects the commit if it finds an SVN_DBG call in the code ... :)
If we were to do that would we allow the use inside #if/ifdef? There
are a few instances of that in the code.
--
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Re: svn commit: r1661671 - /subversion/trunk/subversion/libsvn_wc/wc_db.c
Posted by Stefan Kueng <to...@gmail.com>.
On 23.02.2015 16:42, Bert Huijben wrote:
>
>
>> -----Original Message-----
>> From: Branko Čibej [mailto:brane@wandisco.com]
>> Sent: maandag 23 februari 2015 15:34
>> To: dev@subversion.apache.org
>> Subject: Re: svn commit: r1661671 -
>> /subversion/trunk/subversion/libsvn_wc/wc_db.c
>>
>> On 23.02.2015 14:47, rhuijben@apache.org wrote:
>>> Author: rhuijben
>>> Date: Mon Feb 23 13:47:00 2015
>>> New Revision: 1661671
>>>
>>> URL: http://svn.apache.org/r1661671
>>> Log:
>>> I did it again... I left an SVN_DBG() call :(
>>
>> You've almost given me the motivation to write a pre-commit hook that
>> rejects the commit if it finds an SVN_DBG call in the code ... :)
>
> I should really create a local hook to check for that
> (and to debug the TortoiseSVN compatible local hooks code)
Attached a hook script for TSVN that checks all modified files for an
"SVN_DBG" statement. Errors out if one is found.
It doesn't check for #ifdef's though, so in those cases, you have to
ignore the error and do a "retry without hooks" to commit.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net
RE: svn commit: r1661671 - /subversion/trunk/subversion/libsvn_wc/wc_db.c
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Branko Čibej [mailto:brane@wandisco.com]
> Sent: maandag 23 februari 2015 15:34
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1661671 -
> /subversion/trunk/subversion/libsvn_wc/wc_db.c
>
> On 23.02.2015 14:47, rhuijben@apache.org wrote:
> > Author: rhuijben
> > Date: Mon Feb 23 13:47:00 2015
> > New Revision: 1661671
> >
> > URL: http://svn.apache.org/r1661671
> > Log:
> > I did it again... I left an SVN_DBG() call :(
>
> You've almost given me the motivation to write a pre-commit hook that
> rejects the commit if it finds an SVN_DBG call in the code ... :)
I should really create a local hook to check for that
(and to debug the TortoiseSVN compatible local hooks code)
Bert