You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by vy...@apache.org on 2023/09/04 11:38:58 UTC
[logging-parent] 01/02: Remove redundant build reproducibility check
This is an automated email from the ASF dual-hosted git repository.
vy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/logging-parent.git
commit 1fb5b70b579ad847829db46f628ad5cc9e072d05
Author: Volkan Yazıcı <vo...@yazi.ci>
AuthorDate: Mon Sep 4 13:35:30 2023 +0200
Remove redundant build reproducibility check
---
.github/workflows/build-reusable.yml | 13 +------------
pom.xml | 8 ++++++++
2 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/.github/workflows/build-reusable.yml b/.github/workflows/build-reusable.yml
index 2e5ef59..9a75bf0 100644
--- a/.github/workflows/build-reusable.yml
+++ b/.github/workflows/build-reusable.yml
@@ -62,7 +62,7 @@ jobs:
# `clean verify artifact:compare` is required to generate the build reproducibility report.
# For details, see: https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-to-test-my-maven-build-reproducibility
- - name: Report build reproducibility
+ - name: Verify build reproducibility
shell: bash
run: |
./mvnw \
@@ -70,17 +70,6 @@ jobs:
-DskipTests=true \
clean verify artifact:compare
- - name: Verify build reproducibility
- shell: bash
- run: |
- find . -name target -type d -exec find {} -name "*.buildcompare" \; | while read report_file; do
- if ! grep -q "^ko=0$" "$report_file"; then
- echo "Spotted build reproducibility failure in \`$report_file\`:"
- cat "$report_file"
- echo "fuck"
- fi
- done
-
merge:
runs-on: ubuntu-latest
diff --git a/pom.xml b/pom.xml
index 45ae7f8..c0c1042 100644
--- a/pom.xml
+++ b/pom.xml
@@ -100,6 +100,7 @@
<findsecbugs-plugin.version>1.12.0</findsecbugs-plugin.version>
<flatten-maven-plugin.version>1.5.0</flatten-maven-plugin.version>
<log4j-changelog-maven-plugin.version>0.4.0</log4j-changelog-maven-plugin.version>
+ <maven-artifact-plugin.version>3.4.1</maven-artifact-plugin.version>
<sign-maven-plugin.version>1.0.1</sign-maven-plugin.version>
<spotbugs-maven-plugin.version>4.7.3.5</spotbugs-maven-plugin.version>
<spotless-maven-plugin.version>2.39.0</spotless-maven-plugin.version>
@@ -112,6 +113,13 @@
<pluginManagement>
<plugins>
+ <!-- `artifact:compare` is used in `.github/workflows/build-reusable.yml` -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-artifact-plugin</artifactId>
+ <version>${maven-artifact-plugin.version}</version>
+ </plugin>
+
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>