[GitHub] [airflow] kaxil commented on pull request #14083: Allow users of the KPO to template environment variables

[GitBox <gi...@apache.org>]

kaxil commented on pull request #14083:
URL: https://github.com/apache/airflow/pull/14083#issuecomment-774516166


   @dimberman Master is failing after this PR was merged on k8s tests:
   
   https://github.com/apache/airflow/runs/1842606389#step:9:622
   
   ```
         def test_pod_template_file_with_overrides_system(self):
             fixture = sys.path[0] + '/tests/kubernetes/basic_pod.yaml'
             k = KubernetesPodOperator(
                 task_id="task" + self.get_current_task_name(),
                 labels={"foo": "bar", "fizz": "buzz"},
                 env_vars={"env_name": "value"},
                 in_cluster=False,
                 pod_template_file=fixture,
                 do_xcom_push=True,
             )
         
             context = create_context(k)
             result = k.execute(context)
             assert result is not None
             assert k.pod.metadata.labels == {'fizz': 'buzz', 'foo': 'bar'}
     >       assert k.pod.spec.containers[0].env == [k8s.V1EnvVar(name="env_name", value="value")]
     E       AssertionError: assert [{'name': 'en..._from': None}] == [{'name': 'en..._from': None}]
     E         At index 0 diff: {'name': 'env_name', 'value': 'value', 'value_from': None} != {'name': 'env_name', 'value': 'value', 'value_from': None}
     E         Full diff:
     E           [{'name': 'env_name', 'value': 'value', 'value_from': None}]
     
     kubernetes_tests/test_kubernetes_pod_operator_backcompat.py:587: AssertionError
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org