You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2023/10/12 12:34:00 UTC

[jira] [Closed] (FLINK-33199) ArchitectureTests should test for fully qualified class names instead of Class objects

     [ https://issues.apache.org/jira/browse/FLINK-33199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler closed FLINK-33199.
------------------------------------
    Fix Version/s: 1.19.0
       Resolution: Fixed

master: 71c407a0b94022339319807032982e7ee604cc7e

> ArchitectureTests should test for fully qualified class names instead of Class objects
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-33199
>                 URL: https://issues.apache.org/jira/browse/FLINK-33199
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Alexander Fedulov
>            Assignee: Alexander Fedulov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>
> Currently architecture tests rely on importing such classes as MiniClusterExtension. This introduces a production scope dependency on flink-test-utils which in turn depends on flink-streaming-java. This is problematic because adding architecture tests to any direct or transitive dependency of flink-streaming-java creates a dependency cycle.
> Example: https://github.com/apache/flink/pull/22850#discussion_r1243343382
> In general, since architecture tests are supposed to be used freely in any submodule, it is desirable to reduce its dependency surface as much as possible to prevent such cycles. 
> This can be achieved by moving away from using Class objects and employing fully qualified type names checks instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)