You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/02/18 18:42:10 UTC
[Bug 64157] New: Tomcat 7 performance: enable tomcat to pre-start
pool of min spare threads optionally
https://bz.apache.org/bugzilla/show_bug.cgi?id=64157
Bug ID: 64157
Summary: Tomcat 7 performance: enable tomcat to pre-start pool
of min spare threads optionally
Product: Tomcat 7
Version: trunk
Hardware: All
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: torres.yang@broadcom.com
Target Milestone: ---
Hi Tomcat,
During our performance testing, we found out that tomcat 7 made a mistake on
preStartMinSpareThread.
In Tomcat 6, tomcat doesn't pre-start and maintain a pool of min spare threads,
instead thread pool increased as requests come in.
In Tomcat 7. tomcat made a mistake and pre-start and maintain a pool of min
spare threads, which impacts the performance.
In details:
- In 2010, Tomcat added this commit to OPTIONALLY prestart the core numbers of
workers
https://github.com/apache/tomcat/commit/26fe8127fd51b9b09a8abefa43d63f1f02960e50#diff-aee166200d5b05354b92c2ba73a758f9
And defect track in Bugzila:
https://bz.apache.org/bugzilla/show_bug.cgi?id=43642
- In 2017, Tomcat added this commit to ALWAYS prestart, ignoring the previous
commit, probably by mistake
https://github.com/apache/tomcat/commit/b0e35f94f5dbb24079d29afe0958a4ee02319927#diff-baa9c50854087e10ddd02bd58f546f2a
This change contribute to tomcat performance degradation, and it would improved
tomcat 7 if we are able to optionally start the min spare threads.
Here we attached a patch to solve this problem.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64157] Tomcat 7 performance: enable tomcat to pre-start pool of
min spare threads optionally
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64157
Torres Yang <to...@broadcom.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64157] Tomcat 7 performance: enable tomcat to pre-start pool of
min spare threads optionally
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64157
--- Comment #1 from Torres Yang <to...@broadcom.com> ---
Created attachment 37024
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37024&action=edit
Improved Tomcat 7 performance by allowing start min spare threads optionally
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64157] Tomcat 7 performance: enable tomcat to pre-start pool of
min spare threads optionally
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64157
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |WORKSFORME
--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Two months have passed with no further information being provided. Absent a
text case that demonstrates the issue, I am resolving this as WORKSFORME. If
the issue persists, feel free to re-open this provided the request test case is
supplied.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 64157] Tomcat 7 performance: enable tomcat to pre-start pool of
min spare threads optionally
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64157
Remy Maucherat <re...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Remy Maucherat <re...@apache.org> ---
I don't understand why maintaining the set of min spare threads is bad or how
it affects performance. Please provide metrics.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org