You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/11/29 12:02:44 UTC

[commons-numbers] 01/03: Order of arguments in Junit assertions.

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit 017e03819b61b00ec702ede9264892b849b8b9a9
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Fri Nov 29 12:44:11 2019 +0100

    Order of arguments in Junit assertions.
    
    Reported by "sonarcloud.io".
---
 .../numbers/angle/PlaneAngleRadiansTest.java       | 42 +++++++++++-----------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
index 73c3168..8840a3b 100644
--- a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
+++ b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
@@ -27,16 +27,16 @@ public class PlaneAngleRadiansTest {
     public void testConstants() {
         final double eps = 0;
 
-        Assertions.assertEquals(PlaneAngleRadians.PI, Math.PI, eps);
-        Assertions.assertEquals(PlaneAngleRadians.MINUS_PI, -Math.PI, eps);
+        Assertions.assertEquals(Math.PI, PlaneAngleRadians.PI, eps);
+        Assertions.assertEquals(-Math.PI, PlaneAngleRadians.MINUS_PI, eps);
 
-        Assertions.assertEquals(PlaneAngleRadians.TWO_PI, 2 * Math.PI, eps);
-        Assertions.assertEquals(PlaneAngleRadians.MINUS_TWO_PI, -2 * Math.PI, eps);
+        Assertions.assertEquals(2 * Math.PI, PlaneAngleRadians.TWO_PI, eps);
+        Assertions.assertEquals(-2 * Math.PI, PlaneAngleRadians.MINUS_TWO_PI, eps);
 
-        Assertions.assertEquals(PlaneAngleRadians.PI_OVER_TWO, Math.PI / 2, eps);
-        Assertions.assertEquals(PlaneAngleRadians.MINUS_PI_OVER_TWO, -Math.PI / 2, eps);
+        Assertions.assertEquals(Math.PI / 2, PlaneAngleRadians.PI_OVER_TWO, eps);
+        Assertions.assertEquals(-Math.PI / 2, PlaneAngleRadians.MINUS_PI_OVER_TWO, eps);
 
-        Assertions.assertEquals(PlaneAngleRadians.THREE_PI_OVER_TWO, 3 * Math.PI / 2, eps);
+        Assertions.assertEquals(3 * Math.PI / 2, PlaneAngleRadians.THREE_PI_OVER_TWO, eps);
     }
 
     // Test constants using "sin" and "cos".
@@ -44,26 +44,26 @@ public class PlaneAngleRadiansTest {
     public void testConstants2() {
         final double eps = Math.ulp(1d);
 
-        Assertions.assertEquals(Math.sin(PlaneAngleRadians.PI), 0d, eps);
-        Assertions.assertEquals(Math.cos(PlaneAngleRadians.PI), -1d, eps);
+        Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.PI), eps);
+        Assertions.assertEquals(-1d, Math.cos(PlaneAngleRadians.PI), eps);
 
-        Assertions.assertEquals(Math.sin(PlaneAngleRadians.MINUS_PI), 0d, eps);
-        Assertions.assertEquals(Math.cos(PlaneAngleRadians.MINUS_PI), -1d, eps);
+        Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.MINUS_PI), eps);
+        Assertions.assertEquals(-1d, Math.cos(PlaneAngleRadians.MINUS_PI), eps);
 
-        Assertions.assertEquals(Math.sin(PlaneAngleRadians.TWO_PI), 0d, 2 * eps);
-        Assertions.assertEquals(Math.cos(PlaneAngleRadians.TWO_PI), 1d, eps);
+        Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.TWO_PI), 2 * eps);
+        Assertions.assertEquals(1d, Math.cos(PlaneAngleRadians.TWO_PI), eps);
 
-        Assertions.assertEquals(Math.sin(PlaneAngleRadians.MINUS_TWO_PI), 0d, 2 * eps);
-        Assertions.assertEquals(Math.cos(PlaneAngleRadians.MINUS_TWO_PI), 1d, eps);
+        Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.MINUS_TWO_PI), 2 * eps);
+        Assertions.assertEquals(1d, Math.cos(PlaneAngleRadians.MINUS_TWO_PI), eps);
 
-        Assertions.assertEquals(Math.sin(PlaneAngleRadians.PI_OVER_TWO), 1d, eps);
-        Assertions.assertEquals(Math.cos(PlaneAngleRadians.PI_OVER_TWO), 0d, eps);
+        Assertions.assertEquals(1d, Math.sin(PlaneAngleRadians.PI_OVER_TWO), eps);
+        Assertions.assertEquals(0d, Math.cos(PlaneAngleRadians.PI_OVER_TWO), eps);
 
-        Assertions.assertEquals(Math.sin(PlaneAngleRadians.MINUS_PI_OVER_TWO), -1d, eps);
-        Assertions.assertEquals(Math.cos(PlaneAngleRadians.MINUS_PI_OVER_TWO), 0d, eps);
+        Assertions.assertEquals(-1d, Math.sin(PlaneAngleRadians.MINUS_PI_OVER_TWO), eps);
+        Assertions.assertEquals(0d, Math.cos(PlaneAngleRadians.MINUS_PI_OVER_TWO), eps);
 
-        Assertions.assertEquals(Math.sin(PlaneAngleRadians.THREE_PI_OVER_TWO), -1d, eps);
-        Assertions.assertEquals(Math.cos(PlaneAngleRadians.THREE_PI_OVER_TWO), 0d, eps);
+        Assertions.assertEquals(-1d, Math.sin(PlaneAngleRadians.THREE_PI_OVER_TWO), eps);
+        Assertions.assertEquals(0d, Math.cos(PlaneAngleRadians.THREE_PI_OVER_TWO), eps);
     }
 
     @Test