You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by marchpig <gi...@git.apache.org> on 2016/11/26 06:08:02 UTC
[GitHub] zeppelin pull request #1684: Fix filter icon not displaying problem
GitHub user marchpig opened a pull request:
https://github.com/apache/zeppelin/pull/1684
Fix filter icon not displaying problem
### What is this PR for?
Filter icon is not displayed properly due to the css font-family order.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
### How should this be tested?
See filter input box in the home page or navbar.
### Screenshots (if appropriate)
[Before]
[After]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marchpig/zeppelin fix-filter-icon
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1684
----
commit bc92c4ec0efb48ab80a65bac19b55a7828db7757
Author: Sangwoo Lee <ma...@gmail.com>
Date: 2016-11-26T05:47:22Z
Fix filter icon not displaying problem
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1684
@marchpig Thanks for your prompt response!
As you said I checked `zeppelin-web/dist/styles/main.515f20f02a10e31a.css` after I rebuild the latest master branch like below.
```
$ npm run build
> zeppelin-web@0.0.0 build /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web
> grunt build
Running "jscs:all" (jscs) task
>> 50 files without code style errors.
Running "jscs:test" (jscs) task
>> 8 files without code style errors.
Running "eslint:all" (eslint) task
Running "eslint:test" (eslint) task
Running "htmlhint:src" (htmlhint) task
>> 34 files lint free.
Running "clean:dist" (clean) task
Cleaning .tmp...OK
Cleaning dist/404.html...OK
Cleaning dist/WEB-INF...OK
Cleaning dist/app...OK
Cleaning dist/assets...OK
Cleaning dist/components...OK
Cleaning dist/extensions...OK
Cleaning dist/favicon.ico...OK
Cleaning dist/fonts...OK
Cleaning dist/index.html...OK
Cleaning dist/jax...OK
Cleaning dist/scripts...OK
Cleaning dist/styles...OK
```
This is what I can see `.note-name-query` in `main.515f20f02a10e31a.css`
```
.note-name-query {
padding: 6px;
color: #000;
height: 28px;
width: 200px;
font-size: 14px;
font-family: 'Helvetica Neue', Helvetica, Arial, FontAwesome, sans-serif
}
```
But still can't reproduce.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1684
True. Since both cases (`master` and this patch) are working well for me, I just wanna know which env can cause this problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1684
@marchpig Thanks for your contribution!
I checked the icon in filter bar in latest master branch, but couldn't reproduce this issue. Of course I removed all browser caches and reloaded several times. But still can't see the problem that you faced. I tested Chrome, Safari and Firefox as well. Could you tell us more detailed information about your env?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1684
@marchpig Thanks for this contribution!
I tested it on Ubuntu and It works well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by marchpig <gi...@git.apache.org>.
Github user marchpig commented on the issue:
https://github.com/apache/zeppelin/pull/1684
@AhyoungRyu
This issue occurs on the two different browsers in my environment(Ubuntu 16.04 64-bit).
> Firefox 50.0
> Chromium browser 53.0.2785.143
So I guess it doesn't depend on browsers.
Could you please check whether `.note-name-query` class is the latest in the file below?
> zeppelin/zeppelin-web/dist/styles/main.....css
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by marchpig <gi...@git.apache.org>.
Github user marchpig commented on the issue:
https://github.com/apache/zeppelin/pull/1684
I've tested it on both Win7 and Ubuntu 12.04.
> Win7 32bit (IE11, Chrome 54.0)
> Ubuntu 12.04 64bit (Firefox 43.0)
This issue only occurred on Ubuntu 12.04 so I think @1ambda's guess is reliable.
Is there anyone who can test it on Win7 64bit?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1684
@soralee Thanks for testing it out! Seems it depends on OS as @1ambda said.
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1684: Fix filter icon not displaying problem
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1684
Merge into master if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1684
I am not sure but this might be due to OS
I tested this PR and works well as @marchpig described. (but i didn't reproduce this issue like @AhyoungRyu)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---