You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2026/03/27 21:58:44 UTC
[PR] CI: Fix JMH benchmark workflows [iceberg]
kevinjqliu opened a new pull request, #15800:
URL: https://github.com/apache/iceberg/pull/15800
Spark subproject names now include a Scala version suffix (e.g., `iceberg-spark-3.5_2.12`), which broke JMH benchmark workflows:
> Cannot locate tasks that match ':iceberg-spark:iceberg-spark-3.5:jmh' as project 'iceberg-spark-3.5' not found
https://github.com/apache/iceberg/actions/runs/23668607620/job/68956942458
**Changes:**
- Update `spark_version` from `iceberg-spark-3.5` to `iceberg-spark-3.5_2.12` in both workflows
- Fix `show-matrix` in `jmh-benchmarks.yml` to read `spark_version` from `github.event.inputs` instead of non-existent job output
- Remove invalid `repository`/`ref` checkout params in `recurring-jmh-benchmarks.yml` (schedule trigger has no inputs)
- Add `workflow_dispatch` trigger to `recurring-jmh-benchmarks.yml` for manual runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003646064
##########
site/docs/benchmarks.md:
##########
@@ -28,6 +28,8 @@ Also note that JMH benchmarks run within the same JVM as the system-under-test,
It is possible to run one or more Benchmarks via the **JMH Benchmarks** GH action on your own fork of the Iceberg repo. This GH action takes the following inputs:
* The repository name where those benchmarks should be run against, such as `apache/iceberg` or `<user>/iceberg`
* The branch name to run benchmarks against, such as `main` or `my-cool-feature-branch`
+* The Spark version to use, such as `3.5` (default: `3.5`)
+* The Scala version to use, such as `2.12` (default: `2.12`)
Review Comment:
good catch, done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003692175
##########
.github/workflows/recurring-jmh-benchmarks.yml:
##########
@@ -68,7 +68,7 @@ jobs:
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run Benchmark
- run: ./gradlew :iceberg-spark:${{ matrix.spark_version }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
+ run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{ matrix.scala }} :iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{ matrix.scala }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
Review Comment:
I've tested this PR at #15802. The job failed with:
```
Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003671155
##########
.github/workflows/recurring-jmh-benchmarks.yml:
##########
@@ -68,7 +68,7 @@ jobs:
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run Benchmark
- run: ./gradlew :iceberg-spark:${{ matrix.spark_version }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
+ run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{ matrix.scala }} :iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{ matrix.scala }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
Review Comment:
I sent a similar PR #15729 a few days ago and noticed the `actions/upload-artifact` below fails with the conflicted artifact name. My PR added another step to change the artifact name. Does this PR work without such changes?
I'll close my PR. Please feel to copy the change if needed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #15800:
URL: https://github.com/apache/iceberg/pull/15800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003479829
##########
site/docs/benchmarks.md:
##########
@@ -42,89 +44,89 @@ Below are the existing benchmarks shown with the actual commands on how to run t
### IcebergSourceNestedListParquetDataWriteBenchmark
A benchmark that evaluates the performance of writing nested Parquet data using Iceberg and the built-in file source in Spark. To run this benchmark for either spark-2 or spark-3:
-`./gradlew :iceberg-spark:iceberg-spark-3.5_2.12:jmh -PjmhIncludeRegex=IcebergSourceNestedListParquetDataWriteBenchmark -PjmhOutputPath=benchmark/iceberg-source-nested-list-parquet-data-write-benchmark-result.txt`
+`./gradlew -DsparkVersions=3.5 -DscalaVersion=2.12 :iceberg-spark:iceberg-spark-3.5_2.12:jmh -PjmhIncludeRegex=IcebergSourceNestedListParquetDataWriteBenchmark -PjmhOutputPath=benchmark/iceberg-source-nested-list-parquet-data-write-benchmark-result.txt`
Review Comment:
ran and validated this locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003568357
##########
.github/workflows/jmh-benchmarks.yml:
##########
@@ -28,8 +28,12 @@ on:
description: 'The branch name'
required: true
spark_version:
- description: 'The spark project version to use, such as iceberg-spark-3.5'
- default: 'iceberg-spark-3.5'
+ description: 'The Spark version, such as 3.5'
+ default: '3.5'
Review Comment:
we could! the current default is `iceberg-spark-4.1_2.13`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003697576
##########
.github/workflows/recurring-jmh-benchmarks.yml:
##########
@@ -68,7 +68,7 @@ jobs:
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run Benchmark
- run: ./gradlew :iceberg-spark:${{ matrix.spark_version }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
+ run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{ matrix.scala }} :iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{ matrix.scala }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
Review Comment:
thanks! i ran into this https://github.com/apache/iceberg/actions/runs/23669409378/job/68959473079
cherry picked your commit and fix it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003423157
##########
.github/workflows/jmh-benchmarks.yml:
##########
@@ -28,8 +28,8 @@ on:
description: 'The branch name'
required: true
spark_version:
- description: 'The spark project version to use, such as iceberg-spark-3.5'
- default: 'iceberg-spark-3.5'
+ description: 'The spark project version to use, such as iceberg-spark-3.5_2.12'
+ default: 'iceberg-spark-3.5_2.12'
Review Comment:
see the docs:
https://github.com/apache/iceberg/blob/b9d90533e0e8b376d1fe57a0f25fe30be9d281bf/site/docs/benchmarks.md#L42-L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003671155
##########
.github/workflows/recurring-jmh-benchmarks.yml:
##########
@@ -68,7 +68,7 @@ jobs:
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run Benchmark
- run: ./gradlew :iceberg-spark:${{ matrix.spark_version }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
+ run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{ matrix.scala }} :iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{ matrix.scala }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
Review Comment:
I sent a similar PR #15729 a few days ago and noticed the `actions/upload-artifact` below fails with the conflicted artifact name. My PR added another step to change the artifact name. Does this PR work without such changes?
I'll close my PR. Please feel to copy the change if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003423157
##########
.github/workflows/jmh-benchmarks.yml:
##########
@@ -28,8 +28,8 @@ on:
description: 'The branch name'
required: true
spark_version:
- description: 'The spark project version to use, such as iceberg-spark-3.5'
- default: 'iceberg-spark-3.5'
+ description: 'The spark project version to use, such as iceberg-spark-3.5_2.12'
+ default: 'iceberg-spark-3.5_2.12'
Review Comment:
see the docs:
https://github.com/apache/iceberg/blob/b9d90533e0e8b376d1fe57a0f25fe30be9d281bf/site/docs/benchmarks.md#L42-L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003562606
##########
.github/workflows/jmh-benchmarks.yml:
##########
@@ -28,8 +28,12 @@ on:
description: 'The branch name'
required: true
spark_version:
- description: 'The spark project version to use, such as iceberg-spark-3.5'
- default: 'iceberg-spark-3.5'
+ description: 'The Spark version, such as 3.5'
+ default: '3.5'
Review Comment:
Should we default to 4.1 instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003573569
##########
.github/workflows/jmh-benchmarks.yml:
##########
@@ -28,8 +28,12 @@ on:
description: 'The branch name'
required: true
spark_version:
- description: 'The spark project version to use, such as iceberg-spark-3.5'
- default: 'iceberg-spark-3.5'
+ description: 'The Spark version, such as 3.5'
+ default: '3.5'
Review Comment:
updated! to 4.1 and 2.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003621352
##########
site/docs/benchmarks.md:
##########
@@ -28,6 +28,8 @@ Also note that JMH benchmarks run within the same JVM as the system-under-test,
It is possible to run one or more Benchmarks via the **JMH Benchmarks** GH action on your own fork of the Iceberg repo. This GH action takes the following inputs:
* The repository name where those benchmarks should be run against, such as `apache/iceberg` or `<user>/iceberg`
* The branch name to run benchmarks against, such as `main` or `my-cool-feature-branch`
+* The Spark version to use, such as `3.5` (default: `3.5`)
+* The Scala version to use, such as `2.12` (default: `2.12`)
Review Comment:
also update these two defaults?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] CI: Fix JMH benchmark workflows [iceberg]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #15800:
URL: https://github.com/apache/iceberg/pull/15800#discussion_r3003671155
##########
.github/workflows/recurring-jmh-benchmarks.yml:
##########
@@ -68,7 +68,7 @@ jobs:
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run Benchmark
- run: ./gradlew :iceberg-spark:${{ matrix.spark_version }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
+ run: ./gradlew -DsparkVersions=${{ matrix.spark }} -DscalaVersion=${{ matrix.scala }} :iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{ matrix.scala }}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{ matrix.benchmark }}.txt -PjmhJsonOutputPath=benchmark/${{ matrix.benchmark }}.json
Review Comment:
I sent a similar PR #15729 a few days ago and noticed the `actions/upload-artifact` below fails with the conflicted artifact name. My PR added another step to change the artifact name. Does this PR work without such changes?
(I'll close my PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org