You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Herman van Hovell (JIRA)" <ji...@apache.org> on 2018/04/08 18:27:00 UTC
[jira] [Resolved] (SPARK-23892) Improve coverage and fix lint error
in UTF8String-related Suite
[ https://issues.apache.org/jira/browse/SPARK-23892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herman van Hovell resolved SPARK-23892.
---------------------------------------
Resolution: Fixed
Assignee: Kazuaki Ishizaki
Fix Version/s: 2.4.0
> Improve coverage and fix lint error in UTF8String-related Suite
> ---------------------------------------------------------------
>
> Key: SPARK-23892
> URL: https://issues.apache.org/jira/browse/SPARK-23892
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 2.3.0
> Reporter: Kazuaki Ishizaki
> Assignee: Kazuaki Ishizaki
> Priority: Minor
> Fix For: 2.4.0
>
>
> The following code in {{UTF8StringSuite}} has no sense.
> {code}
> assertTrue(s1.startsWith(s1));
> assertTrue(s1.endsWith(s1));
> {code}
> The code {{if (length <= 0) ""}} in {{UTF8StringPropertyCheckSuite}} has no sense
> {code}
> test("lpad, rpad") {
> def padding(origin: String, pad: String, length: Int, isLPad: Boolean): String = {
> if (length <= 0) return ""
> if (length <= origin.length) {
> if (length <= 0) "" else origin.substring(0, length)
> } else {
> ...
> {code}
> The previous change in {{UTF8StringSuite}} broke lint-java check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org