[jira] [Commented] (MAPREDUCE-2629) Class loading quirk prevents inner class method compilation

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131982#comment-13131982 ] 

Hadoop QA commented on MAPREDUCE-2629:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12499918/mr-2629.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 160 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1087//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1087//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1087//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1087//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1087//console

This message is automatically generated.
                
> Class loading quirk prevents inner class method compilation
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2629
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2629
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: task
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Eric Caspole
>            Assignee: Eric Caspole
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2629.patch, mr-2629.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> While profiling jobs like terasort and gridmix, I noticed that a
> method "org.apache.hadoop.mapreduce.task.ReduceContextImpl.access
> $000" is near the top. It turns out that this is because the
> ReduceContextImpl class has a member backupStore which is accessed
> from an inner class ReduceContextImpl$ValueIterator. Due to the way
> synthetic accessor methods work, every access of backupStore results
> in a call to access$000 to the outer class. For some portion of the
> run, backupStore is null and the BackupStore class has never been
> loaded by the reducer.
> Due to the way the Hotspot JVM inliner works, by default it will not
> inline a short method where the class of of the return value object
> is unloaded - if you use a debug JVM with -XX:+PrintCompilation you
> will see a failure reason message like "unloaded signature classes."
> This causes every call to ReduceContextImpl.access$000 to be executed
> in the interpreter for the handful of bytecodes to return the null
> backupStore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira