[GitHub] [hudi] parisni commented on a diff in pull request #8683: [HUDI-5533] Support spark columns comments

["parisni (via GitHub)" <gi...@apache.org>]

parisni commented on code in PR #8683:
URL: https://github.com/apache/hudi/pull/8683#discussion_r1293889135


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/JDBCExecutor.java:
##########
@@ -65,7 +65,7 @@ public void runSQL(String s) {
     try {
       stmt = connection.createStatement();
       LOG.info("Executing SQL " + s);
-      stmt.execute(s);
+      stmt.execute(escapeAntiSlash(s));

Review Comment:
   yes, both JDBC and HMS generate sql and antislash should be doubled escaped otherwise it is lost.
   
   Antislash is used to escape double quotes in the comments DDL. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org