You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by si...@apache.org on 2011/05/31 18:16:18 UTC

svn commit: r1129774 - /commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java

Author: simonetripodi
Date: Tue May 31 16:16:18 2011
New Revision: 1129774

URL: http://svn.apache.org/viewvc?rev=1129774&view=rev
Log:
back to old iterators, the `ruleLoader == null` condition fixes the broken tests

Modified:
    commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java

Modified: commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java
URL: http://svn.apache.org/viewvc/commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java?rev=1129774&r1=1129773&r2=1129774&view=diff
==============================================================================
--- commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java (original)
+++ commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java Tue May 31 16:16:18 2011
@@ -20,6 +20,7 @@ package org.apache.commons.digester3.plu
  */
 
 import java.util.HashMap;
+import java.util.Iterator;
 import java.util.List;
 import java.util.Properties;
 
@@ -172,8 +173,10 @@ public class PluginManager
 
         List<RuleFinder> ruleFinders = pluginContext.getRuleFinders();
         RuleLoader ruleLoader = null;
-        for ( RuleFinder finder : ruleFinders )
+        for ( Iterator<RuleFinder> i = ruleFinders.iterator(); i.hasNext() && ruleLoader == null; )
         {
+
+            RuleFinder finder = i.next();
             if ( debug )
             {
                 log.debug( "checking finder of type " + finder.getClass().getName() );