You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by giacomo <gi...@apache.org> on 2001/06/07 21:47:31 UTC

Re: cvs commit: xml-cocoon2/src/org/apache/cocoon/sitemap sitemap.roles

On 7 Jun 2001 bloritsch@apache.org wrote:

Just some question. Where is the SitemapRedirector class?


> bloritsch    01/06/07 09:24:06
>
>   Modified:    src/org/apache/cocoon Tag: cocoon_20_branch cocoon.roles
>                src/org/apache/cocoon/components/language/markup/sitemap/java
>                         Tag: cocoon_20_branch sitemap.xsl
>                src/org/apache/cocoon/components/pipeline Tag:
>                         cocoon_20_branch AbstractEventPipeline.java
>                         AbstractStreamPipeline.java
>                         CachingEventPipeline.java
>                         CachingStreamPipeline.java EventPipeline.java
>                         StreamPipeline.java
>                src/org/apache/cocoon/sitemap Tag: cocoon_20_branch
>                         sitemap.roles
>   Log:
>   Add SitemapRedirector--works like a charm


>   + <role name="org.apache.cocoon.components.pipeline.StreamPipeline"
>   +       shorthand="stream-pipeline"
>   +       default-class="org.apache.cocoon.components.pipeline.NonCachingStreamPipeline"/>
>   +
>   + <role name="org.apache.cocoon.components.pipeline.EventPipeline"
>   +       shorthand="event-pipeline"
>   +       default-class="org.apache.cocoon.components.pipeline.NonCachingEventPipeline"/>

NonCaching stuff as default?

>   -        if ((map = <xsl:value-of select="$action-name"/> ((Redirector)environment, environment, objectModel, substitute(listOfMaps,<xsl:value-of select="$action-source"/>), <xsl:value-of select="$component-param"/>)) != null) {
>   +        if ((map = <xsl:value-of select="$action-name"/> (redirector, environment, objectModel, substitute(listOfMaps,<xsl:value-of select="$action-source"/>), <xsl:value-of select="$component-param"/>)) != null) {
>   +         if (redirector.hasRedirected()) {
>   +             return true;
>   +         }
>             getLogger().debug("Action <xsl:value-of select="translate($action-name,'&quot;',' ')"/>");
>              listOfMaps.add (map);
>              <xsl:apply-templates/>
>              listOfMaps.remove(listOfMaps.size()-1);
>            }
>   +         if (redirector.hasRedirected()) {
>   +             return true;
>   +         }

The above seems to be ok but...

>   -        if ((map = <xsl:value-of select="$action-name"/> ((Redirector)environment, environment, objectModel, substitute(listOfMaps,<xsl:value-of select="$action-source"/>), <xsl:value-of select="$component-param"/>)) != null) {
>   +        if ((map = <xsl:value-of select="$action-name"/> (redirector, environment, objectModel, substitute(listOfMaps,<xsl:value-of select="$action-source"/>), <xsl:value-of select="$component-param"/>)) != null) {
>             getLogger().debug("Action <xsl:value-of select="translate($action-name,'&quot;',' ')"/>");
>              listOfMaps.add (map);
>              <xsl:apply-templates/>
>   @@ -821,7 +835,7 @@

..shouldn't there be a redirector test as well in the last snippet?


Giacomo


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/org/apache/cocoon/sitemap sitemap.roles

Posted by Berin Loritsch <bl...@apache.org>.
Berin Loritsch wrote:
> 
> giacomo wrote:
> >
> > On 7 Jun 2001 bloritsch@apache.org wrote:
> >
> > Just some question. Where is the SitemapRedirector class?
> 
> It should be in there--let me double check.

My mistake.  I added it now.

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/org/apache/cocoon/sitemap sitemap.roles

Posted by Berin Loritsch <bl...@apache.org>.
giacomo wrote:
> 
> On 7 Jun 2001 bloritsch@apache.org wrote:
> 
> Just some question. Where is the SitemapRedirector class?

It should be in there--let me double check.

> > bloritsch    01/06/07 09:24:06
> >
> >   Modified:    src/org/apache/cocoon Tag: cocoon_20_branch cocoon.roles
> >                src/org/apache/cocoon/components/language/markup/sitemap/java
> >                         Tag: cocoon_20_branch sitemap.xsl
> >                src/org/apache/cocoon/components/pipeline Tag:
> >                         cocoon_20_branch AbstractEventPipeline.java
> >                         AbstractStreamPipeline.java
> >                         CachingEventPipeline.java
> >                         CachingStreamPipeline.java EventPipeline.java
> >                         StreamPipeline.java
> >                src/org/apache/cocoon/sitemap Tag: cocoon_20_branch
> >                         sitemap.roles
> >   Log:
> >   Add SitemapRedirector--works like a charm
> 
> >   + <role name="org.apache.cocoon.components.pipeline.StreamPipeline"
> >   +       shorthand="stream-pipeline"
> >   +       default-class="org.apache.cocoon.components.pipeline.NonCachingStreamPipeline"/>
> >   +
> >   + <role name="org.apache.cocoon.components.pipeline.EventPipeline"
> >   +       shorthand="event-pipeline"
> >   +       default-class="org.apache.cocoon.components.pipeline.NonCachingEventPipeline"/>
> 
> NonCaching stuff as default?

yes--but again, I am working on getting this thing to handle subsitemaps with Avalon B3.
Avalon 4.0b3 is stricter in enforcing write once--so once the ComponentManager is initialized,
it is read-only.  This is no different than when this was in cocoon.roles.  I am trying to
move it back to cocoon.roles--but I am running into some issues.  Will have it fixed soon.

> >   -        if ((map = <xsl:value-of select="$action-name"/> ((Redirector)environment, environment, objectModel, substitute(listOfMaps,<xsl:value-of select="$action-source"/>), <xsl:value-of select="$component-param"/>)) != null) {
> >   +        if ((map = <xsl:value-of select="$action-name"/> (redirector, environment, objectModel, substitute(listOfMaps,<xsl:value-of select="$action-source"/>), <xsl:value-of select="$component-param"/>)) != null) {
> >             getLogger().debug("Action <xsl:value-of select="translate($action-name,'&quot;',' ')"/>");
> >              listOfMaps.add (map);
> >              <xsl:apply-templates/>
> >   @@ -821,7 +835,7 @@
> 
> ..shouldn't there be a redirector test as well in the last snippet?

No.  This snippet lives in the "action_set_${name}(...)" method which returns
a Map.  The approach I took was to allow the whole set to be processed as it would
otherwise have been done, and test for redirect when we return from the set
processing.

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org