You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/22 14:50:00 UTC

[jira] [Commented] (NIFI-5482) Make Write-Ahead Provenance Repository the default implementation

    [ https://issues.apache.org/jira/browse/NIFI-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588955#comment-16588955 ] 

ASF GitHub Bot commented on NIFI-5482:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2960

    NIFI-5482: Made WriteAheadProvenanceRepository the default implementa…

    …tion
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5482

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2960
    
----
commit ead059940feb4b50d4badb6d3cd536097b673b90
Author: Mark Payne <ma...@...>
Date:   2018-08-22T14:48:47Z

    NIFI-5482: Made WriteAheadProvenanceRepository the default implementation

----


> Make Write-Ahead Provenance Repository the default implementation
> -----------------------------------------------------------------
>
>                 Key: NIFI-5482
>                 URL: https://issues.apache.org/jira/browse/NIFI-5482
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Configuration
>            Reporter: Mark Payne
>            Priority: Major
>              Labels: beginner, newbie
>             Fix For: 1.8.0
>
>
> The default implementation for the Provenance Repository is the PersistentProvenanceRepository. The WriteAheadProvenanceRepository was added in version 1.2.0 of NiFi. We left the default as the PersistentProvenanceRepository only because it had been heavily tested over years of production use. Since then, the WriteAheadProvenanceRepository has proven to be not only significantly faster but also more stable and easier to maintain. When problems arise with the PersistentProvenanceRepository, the solution almost always is to change to the WriteAheadProvenanceRepository. Given this, we should now change the default implementation to be the WriteAheadProvenanceRepository.
> This involves changing the default value in the POM of nifi-resources and also updating the Admin Guide to note the new default and review the guide for any other wording that may need to be updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)