You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/09/13 15:03:12 UTC

[GitHub] [avro] opwvhk commented on a diff in pull request #1863: AVRO-3628: [Java] JUnit 4.x tests are not executed

opwvhk commented on code in PR #1863:
URL: https://github.com/apache/avro/pull/1863#discussion_r969746571


##########
lang/java/archetypes/avro-service-archetype/src/main/pom/pom.xml:
##########
@@ -79,9 +79,9 @@
       <version>\${logback.version}</version>
     </dependency>
     <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>\${junit.version}</version>
+      <groupId>org.junit.vintage</groupId>
+      <artifactId>junit-vintage-engine</artifactId>
+      <version>\${junit5.version}</version>

Review Comment:
   This looks like it (only) uses the vintage engine. Do we also want to run JUnit5 (Jupiter) tests?
   
   In that case, we also need to add the Jupiter engine IIRC.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org