You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King III (JIRA)" <ji...@apache.org> on 2019/02/10 13:03:00 UTC
[jira] [Closed] (THRIFT-2252) Optimize the overhead of the tag
message of the request
[ https://issues.apache.org/jira/browse/THRIFT-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James E. King III closed THRIFT-2252.
-------------------------------------
Resolution: Won't Do
Assignee: James E. King III
Closing - having numerically identified services was discussed in THRIFT-66 and it was one of my first implementations of multiplex, but it required changes to the IDL and folks didn't like it, so we stuck with name strings.
As stated, anything in this area would need to be considered another protocol OR a new version of an existing protocol. It would likely require some sort of annotation in the IDL like:
{noformat}
service MyService : slot 4 { ... }
{noformat}
As such, closing.
> Optimize the overhead of the tag message of the request
> -------------------------------------------------------
>
> Key: THRIFT-2252
> URL: https://issues.apache.org/jira/browse/THRIFT-2252
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: George Cao
> Assignee: James E. King III
> Priority: Minor
> Labels: optimization, payload, perfomance
>
> For now, every request the client sent consists of a tag message(TMessage) and the API arguments.
> This tag message includes the API name(method name), message type and a sequence ID.
> Compare to the API arguments which usually are some structure data like integers, the tag message will cause a lot of overhead because of the API name string.
> For example, assume we have an API like this in Java:
> {code}
> int getSomeEntityById(int id);
> {code}
> The the tag message will takes *len("getSomeEntityById") + 1 + 4 = 22* bytes and the API arguments only takes 4 bytes.
>
> Even worse if we support multiplexing, because we need append additional service name at the beginning of the API name.
> So shall we assign an ID to each API like struct's every property has an ID? Then we can avoid using the verbose string names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)