You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/09 07:23:29 UTC

[GitHub] [beam] alexvanboxel commented on issue #11074: Store logical type values in Row instead of base values

alexvanboxel commented on issue #11074: Store logical type values in Row instead of base values
URL: https://github.com/apache/beam/pull/11074#issuecomment-596367911
 
 
   I can review the PR only this evening, but the first question that pops into my mind is:
   What traits does the logical type need to have to play nice with Beam:
   - Does it need to be comparable?
   - Does the equal need to have proper behaviour?
   These things we have control over when storing and working with the base type.
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services