[GitHub] [spark] cloud-fan commented on a change in pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29737:
URL: https://github.com/apache/spark/pull/29737#discussion_r490808895



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -142,13 +142,17 @@ object OrcUtils extends Logging {
       reader: Reader,
       conf: Configuration): Option[(Array[Int], Boolean)] = {
     val orcFieldNames = reader.getSchema.getFieldNames.asScala
+    val forcePositionalEvolution = OrcConf.FORCE_POSITIONAL_EVOLUTION.getBoolean(conf)

Review comment:
       this doesn't look like a reasonable config for a data source, but more like a config for the upper level that maps metastore schema with the ORC files.
   
   Do we have a good story for the schema evolution of spark file sources?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org