[GitHub] [maven-release] michael-o commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r883804882


##########
maven-release-plugin/src/it/setup/maven-project-version-stub-policy/pom.xml:
##########
@@ -43,15 +43,15 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>2.0.2</version>
+        <version>@maven-compiler-plugin.version@</version>
         <configuration>
           <encoding>UTF-8</encoding>
         </configuration>
       </plugin>
       <plugin>
         <groupId>org.codehaus.plexus</groupId>
         <artifactId>plexus-component-metadata</artifactId>
-        <version>1.7.1</version>
+        <version>@plexus-component-metadata.version@</version>

Review Comment:
   @cstamas Do we need this with Sisu?



##########
maven-release-plugin/pom.xml:
##########
@@ -109,7 +109,7 @@
     <dependency>
       <groupId>org.apache.maven.plugin-testing</groupId>
       <artifactId>maven-plugin-testing-harness</artifactId>
-      <version>3.3.0</version>
+      <version>${maven-plugin-testing-harness.version}</version>

Review Comment:
   This is used only once, we can safely use the literal, this is what we do everywhere.



##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
           <plugin>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-maven-plugin</artifactId>
-            <version>1.3.8</version>
+            <version>${plexus-maven-plugin.version}</version>

Review Comment:
   @cstamas Do we need this plugin at all?



##########
maven-release-plugin/src/it/projects/prepare/semver-policy/pom.xml:
##########
@@ -21,7 +21,7 @@
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
   <modelVersion>4.0.0</modelVersion>
   <groupId>org.apache.maven.plugin.release.it</groupId>
-  <artifactId>oddversion-policy</artifactId>
+  <artifactId>semver-policy</artifactId>

Review Comment:
   Is that a bugfix?



##########
pom.xml:
##########
@@ -93,8 +96,20 @@
     <resolverVersion>1.0.0.v20140518</resolverVersion>
     <wagonVersion>3.5.1</wagonVersion>
     <surefire.version>3.0.0-M6</surefire.version>
+    <slf4j.version>1.7.36</slf4j.version>
+    <junit.version>4.13.2</junit.version>
     <maven.site.path>maven-release-archives/maven-release-LATEST</maven.site.path>
     <project.build.outputTimestamp>2022-01-02T10:18:49Z</project.build.outputTimestamp>
+
+    <maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version>
+    <maven-artifact-transfer.version>0.13.1</maven-artifact-transfer.version>
+    <maven-invoker-plugin.version>3.2.2</maven-invoker-plugin.version>
+
+    <plexus-component-metadata.version>1.7.1</plexus-component-metadata.version>
+    <plexus-maven-plugin.version>1.3.8</plexus-maven-plugin.version>
+
+    <maven-plugin-testing-harness.version>3.3.0</maven-plugin-testing-harness.version>

Review Comment:
   We tend to use camel case for those kind of properties, see here: https://github.com/apache/maven-scm/blob/b04525fa0716e6de7a65bf9970284efa0e49b177/pom.xml#L128



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org