You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Ben Johnson (JIRA)" <ji...@apache.org> on 2012/05/28 18:18:22 UTC
[jira] [Created] (SHIRO-368) DomainPermission(string, string)
constructor sets targets to the same value as actions
Ben Johnson created SHIRO-368:
---------------------------------
Summary: DomainPermission(string, string) constructor sets targets to the same value as actions
Key: SHIRO-368
URL: https://issues.apache.org/jira/browse/SHIRO-368
Project: Shiro
Issue Type: Bug
Components: Authorization (access control)
Affects Versions: 1.2.0
Environment: Windows XP SP3, Intel Core2 Duo
Reporter: Ben Johnson
Priority: Minor
The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
055 public DomainPermission(String actions, String targets) {
056 this.domain = getDomain(getClass());
057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
059 encodeParts(this.domain, actions, targets);
060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHIRO-368) DomainPermission(string, string)
constructor sets targets to the same value as actions
Posted by "Jared Bunting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jared Bunting resolved SHIRO-368.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.3.0
1.2.1
Assignee: Jared Bunting
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-368
> URL: https://issues.apache.org/jira/browse/SHIRO-368
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.0
> Environment: Windows XP SP3, Intel Core2 Duo
> Reporter: Ben Johnson
> Assignee: Jared Bunting
> Priority: Minor
> Fix For: 1.2.1, 1.3.0
>
> Attachments: DomainPermission.java, DomainPermission.patch, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055 public DomainPermission(String actions, String targets) {
> 056 this.domain = getDomain(getClass());
> 057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059 encodeParts(this.domain, actions, targets);
> 060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHIRO-368) DomainPermission(string, string)
constructor sets targets to the same value as actions
Posted by "Ben Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284459#comment-13284459 ]
Ben Johnson commented on SHIRO-368:
-----------------------------------
Patch based on code in 1.2.1 branch
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-368
> URL: https://issues.apache.org/jira/browse/SHIRO-368
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.0
> Environment: Windows XP SP3, Intel Core2 Duo
> Reporter: Ben Johnson
> Priority: Minor
> Attachments: DomainPermission.java, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055 public DomainPermission(String actions, String targets) {
> 056 this.domain = getDomain(getClass());
> 057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059 encodeParts(this.domain, actions, targets);
> 060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHIRO-368) DomainPermission(string, string)
constructor sets targets to the same value as actions
Posted by "Jared Bunting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419977#comment-13419977 ]
Jared Bunting commented on SHIRO-368:
-------------------------------------
I'm adding this patch and test. However, I've modified all of the assertions in the test to be more comprehensive than just "assertTrue".
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-368
> URL: https://issues.apache.org/jira/browse/SHIRO-368
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.0
> Environment: Windows XP SP3, Intel Core2 Duo
> Reporter: Ben Johnson
> Priority: Minor
> Attachments: DomainPermission.java, DomainPermission.patch, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055 public DomainPermission(String actions, String targets) {
> 056 this.domain = getDomain(getClass());
> 057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059 encodeParts(this.domain, actions, targets);
> 060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHIRO-368) DomainPermission(string, string)
constructor sets targets to the same value as actions
Posted by "Ben Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Johnson updated SHIRO-368:
------------------------------
Attachment: DomainPermission.patch
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-368
> URL: https://issues.apache.org/jira/browse/SHIRO-368
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.0
> Environment: Windows XP SP3, Intel Core2 Duo
> Reporter: Ben Johnson
> Priority: Minor
> Attachments: DomainPermission.java, DomainPermission.patch, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055 public DomainPermission(String actions, String targets) {
> 056 this.domain = getDomain(getClass());
> 057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059 encodeParts(this.domain, actions, targets);
> 060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SHIRO-368) DomainPermission(string,
string) constructor sets targets to the same value as actions
Posted by "Ben Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284459#comment-13284459 ]
Ben Johnson edited comment on SHIRO-368 at 5/28/12 4:33 PM:
------------------------------------------------------------
Patch based on code in 1.2.x branch
was (Author: b.johnson):
Patch based on code in 1.2.1 branch
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-368
> URL: https://issues.apache.org/jira/browse/SHIRO-368
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.0
> Environment: Windows XP SP3, Intel Core2 Duo
> Reporter: Ben Johnson
> Priority: Minor
> Attachments: DomainPermission.java, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055 public DomainPermission(String actions, String targets) {
> 056 this.domain = getDomain(getClass());
> 057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059 encodeParts(this.domain, actions, targets);
> 060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHIRO-368) DomainPermission(string, string)
constructor sets targets to the same value as actions
Posted by "Ben Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Johnson updated SHIRO-368:
------------------------------
Attachment: DomainPermissionTest.java
DomainPermission.java
Attached patch with constructor unit tests
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-368
> URL: https://issues.apache.org/jira/browse/SHIRO-368
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.0
> Environment: Windows XP SP3, Intel Core2 Duo
> Reporter: Ben Johnson
> Priority: Minor
> Attachments: DomainPermission.java, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055 public DomainPermission(String actions, String targets) {
> 056 this.domain = getDomain(getClass());
> 057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059 encodeParts(this.domain, actions, targets);
> 060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHIRO-368) DomainPermission(string, string)
constructor sets targets to the same value as actions
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Les Hazlewood closed SHIRO-368.
-------------------------------
Closing per the 1.2.1 release.
> DomainPermission(string, string) constructor sets targets to the same value as actions
> --------------------------------------------------------------------------------------
>
> Key: SHIRO-368
> URL: https://issues.apache.org/jira/browse/SHIRO-368
> Project: Shiro
> Issue Type: Bug
> Components: Authorization (access control)
> Affects Versions: 1.2.0
> Environment: Windows XP SP3, Intel Core2 Duo
> Reporter: Ben Johnson
> Assignee: Jared Bunting
> Priority: Minor
> Fix For: 1.2.1, 1.3.0
>
> Attachments: DomainPermission.java, DomainPermission.patch, DomainPermissionTest.java
>
>
> The DomainPermission(string, string) constructor incorrectly sets the 'targets' field to the value supplied for 'actions':
> 055 public DomainPermission(String actions, String targets) {
> 056 this.domain = getDomain(getClass());
> 057 this.actions = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 058 this.targets = StringUtils.splitToSet(actions, SUBPART_DIVIDER_TOKEN);
> 059 encodeParts(this.domain, actions, targets);
> 060 }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira