You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Sambavi Muthukrishnan (JIRA)" <ji...@apache.org> on 2012/09/05 16:43:07 UTC

[jira] [Created] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Sambavi Muthukrishnan created HIVE-3433:
-------------------------------------------

             Summary: Implement CUBE and ROLLUP operators in Hive
                 Key: HIVE-3433
                 URL: https://issues.apache.org/jira/browse/HIVE-3433
             Project: Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.9.0
            Reporter: Sambavi Muthukrishnan




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-3433:
---------------------------------

    Status: Open  (was: Patch Available)

@Namit: I left some comments on phabricator. Thanks.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Attachment: hive.3433.1.patch
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Attachment: hive.3433.2.patch
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Status: Patch Available  (was: Open)
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Shreepadma Venugopalan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467256#comment-13467256 ] 

Shreepadma Venugopalan commented on HIVE-3433:
----------------------------------------------

@Namit: I left comments on phabricator.Thanks.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Attachment:     (was: hive.3433.1.patch)
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3433:
--------------------------------

    Affects Version/s: 0.10.0
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch, hive-3433.5.patch, hive-3433.6.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481756#comment-13481756 ] 

Kevin Wilfong commented on HIVE-3433:
-------------------------------------

A few more comments, fairly small.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484756#comment-13484756 ] 

Hudson commented on HIVE-3433:
------------------------------

Integrated in Hive-trunk-h0.21 #1758 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1758/])
    HIVE-3433. Implement CUBE and ROLLUP operators in Hive. (Ivan Gorbachev and Namit Jain via kevinwilfong) (Revision 1402245)

     Result = FAILURE
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1402245
Files : 
* /hive/trunk/eclipse-templates/.classpath
* /hive/trunk/ivy/libraries.properties
* /hive/trunk/ql/build.xml
* /hive/trunk/ql/ivy.xml
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java
* /hive/trunk/ql/src/test/queries/clientnegative/groupby_cube1.q
* /hive/trunk/ql/src/test/queries/clientnegative/groupby_cube2.q
* /hive/trunk/ql/src/test/queries/clientnegative/groupby_rollup1.q
* /hive/trunk/ql/src/test/queries/clientnegative/groupby_rollup2.q
* /hive/trunk/ql/src/test/queries/clientpositive/groupby_cube1.q
* /hive/trunk/ql/src/test/queries/clientpositive/groupby_rollup1.q
* /hive/trunk/ql/src/test/results/clientnegative/groupby_cube1.q.out
* /hive/trunk/ql/src/test/results/clientnegative/groupby_cube2.q.out
* /hive/trunk/ql/src/test/results/clientnegative/groupby_rollup1.q.out
* /hive/trunk/ql/src/test/results/clientnegative/groupby_rollup2.q.out
* /hive/trunk/ql/src/test/results/clientpositive/groupby_cube1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/groupby_rollup1.q.out
* /hive/trunk/ql/src/test/results/compiler/plan/groupby1.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/groupby2.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/groupby3.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/groupby4.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/groupby5.q.xml
* /hive/trunk/ql/src/test/results/compiler/plan/groupby6.q.xml

                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch, hive-3433.5.patch, hive-3433.6.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Attachment: hive.3433.3.patch
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482643#comment-13482643 ] 

Ivan Gorbachev commented on HIVE-3433:
--------------------------------------

Fixed comments - https://reviews.facebook.net/D6141
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Shreepadma Venugopalan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468686#comment-13468686 ] 

Shreepadma Venugopalan commented on HIVE-3433:
----------------------------------------------

Thanks for making the change, Namit.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Attachment: hive.3433.1.patch
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456762#comment-13456762 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation,+Cube,+Grouping+and+Rollup
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Issue Type: New Feature  (was: Bug)
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain reassigned HIVE-3433:
--------------------------------

    Assignee: Namit Jain
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466286#comment-13466286 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

All the tests passed.

The current implementation can be optimized.
In this patch, at the time of aggregation, all the values corresponding to the grouping sets are passed.
This will increase the data across the map-reduce boundary.
It is still better than the current work-around for the cube and rollup in hive, which is to perform
multiple group bys for the same base table.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Gorbachev updated HIVE-3433:
---------------------------------

    Attachment: hive-3433.6.patch
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch, hive-3433.5.patch, hive-3433.6.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469134#comment-13469134 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

The tests finished successfully
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461713#comment-13461713 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

https://reviews.facebook.net/D5619
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475060#comment-13475060 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

[~kevinwilfong], addressed comments
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong resolved HIVE-3433.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.10.0

Committed, thanks Namit and Ivan.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>    Affects Versions: 0.10.0
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>             Fix For: 0.10.0
>
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch, hive-3433.5.patch, hive-3433.6.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Gorbachev reassigned HIVE-3433:
------------------------------------

    Assignee: Namit Jain  (was: Ivan Gorbachev)
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Affects Version/s:     (was: 0.9.0)
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Gorbachev updated HIVE-3433:
---------------------------------

    Attachment: hive-3433.5.patch
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch, hive-3433.5.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468684#comment-13468684 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

[~shreepadma], thanks - using fastbitset instead.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471704#comment-13471704 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

addressed all comments
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483479#comment-13483479 ] 

Kevin Wilfong commented on HIVE-3433:
-------------------------------------

+1 Looks good.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch, hive-3433.5.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Gorbachev reassigned HIVE-3433:
------------------------------------

    Assignee: Ivan Gorbachev  (was: Namit Jain)
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Ivan Gorbachev
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Sambavi Muthukrishnan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448787#comment-13448787 ] 

Sambavi Muthukrishnan commented on HIVE-3433:
---------------------------------------------

Provide an efficient implementation of CUBE and ROLLUP in Hive. We can use a group by followed by adding rows and re-grouping to provide the CUBE/ROLLUP.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.9.0
>            Reporter: Sambavi Muthukrishnan
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-3433:
--------------------------------

    Status: Open  (was: Patch Available)
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Ivan Gorbachev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Gorbachev updated HIVE-3433:
---------------------------------

    Attachment: hive-3433.4.patch
    
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch, hive.3433.3.patch, hive-3433.4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-3433:
-----------------------------

    Status: Patch Available  (was: Open)

addressed comments
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467421#comment-13467421 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

I will respond to the comments and upload a new patch.
Thanks for taking a look.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466742#comment-13466742 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

Optimized the patch.
This is ready for review.
If a rollup/cube is being performed, hash aggregation is always used.
The possible keys are computed, and the group by operator behaves as if
it received multiple keys (one per grouping set) from the upstream operator.
                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3433) Implement CUBE and ROLLUP operators in Hive

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468492#comment-13468492 ] 

Namit Jain commented on HIVE-3433:
----------------------------------

Shreepadma, I saw your ivy.xml changes in https://reviews.apache.org/r/6878/diff/?page=1.
I can do the conversion of bitset to fastbitset once your jira is in.


                
> Implement CUBE and ROLLUP operators in Hive
> -------------------------------------------
>
>                 Key: HIVE-3433
>                 URL: https://issues.apache.org/jira/browse/HIVE-3433
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Sambavi Muthukrishnan
>            Assignee: Namit Jain
>         Attachments: hive.3433.1.patch, hive.3433.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira