[GitHub] spark pull request: [SPARK-14949][SQL] Remove HiveConf dependency ...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12728#discussion_r65092509
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala ---
    @@ -114,13 +110,15 @@ case class InsertIntoHiveTable(
         // Validate partition spec if there exist any dynamic partitions
         if (numDynamicPartitions > 0) {
           // Report error if dynamic partitioning is not enabled
    -      if (!hiveconf.getBoolVar(HiveConf.ConfVars.DYNAMICPARTITIONING)) {
    +      if (!sessionState.conf.getConfString("hive.exec.dynamic.partition", "true").toBoolean) {
    --- End diff --
    
    In Hive, the default value is `false` to avoid accidental partition creation. Any reason why we change the default to `true` here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org