You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2017/05/31 06:10:13 UTC

[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...

Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18129#discussion_r119277116
  
    --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
    @@ -116,15 +116,16 @@ class ClientSuite extends SparkFunSuite with Matchers with BeforeAndAfterAll
         val cp = env("CLASSPATH").split(":|;|<CPS>")
         s"$SPARK,$USER,$ADDED".split(",").foreach({ entry =>
           val uri = new URI(entry)
    -      if (LOCAL_SCHEME.equals(uri.getScheme())) {
    -        cp should contain (uri.getPath())
    +      if (LOCAL_SCHEME.equals(uri.getScheme)) {
    +        cp should contain (uri.getPath)
    --- End diff --
    
    Maybe it is not so necessary to change the previous style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org