[jira] [Commented] (SPARK-22359) Improve the test coverage of window functions

["Teng Peng (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-22359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241392#comment-16241392 ] 

Teng Peng commented on SPARK-22359:
-----------------------------------

[~jiangxb] If I can have 1 test as reference, I will figure out the rests myself.

> Improve the test coverage of window functions
> ---------------------------------------------
>
>                 Key: SPARK-22359
>                 URL: https://issues.apache.org/jira/browse/SPARK-22359
>             Project: Spark
>          Issue Type: Test
>          Components: SQL
>    Affects Versions: 2.3.0
>            Reporter: Jiang Xingbo
>
> There are already quite a few integration tests using window functions, but the unit tests coverage for window funtions is not ideal.
> We'd like to test the following aspects:
> * Specifications
> ** different partition clauses (none, one, multiple)
> ** different order clauses (none, one, multiple, asc/desc, nulls first/last)
> * Frames and their combinations
> ** OffsetWindowFunctionFrame
> ** UnboundedWindowFunctionFrame
> ** SlidingWindowFunctionFrame
> ** UnboundedPrecedingWindowFunctionFrame
> ** UnboundedFollowingWindowFunctionFrame
> * Aggregate function types
> ** Declarative
> ** Imperative
> ** UDAF
> * Spilling
> ** Cover the conditions that WindowExec should spill at least once 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org