You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/03/21 09:12:53 UTC

[GitHub] [arrow] jorisvandenbossche opened a new pull request, #34654: GH-34248: [Python] Expose the order_by node

jorisvandenbossche opened a new pull request, #34654:
URL: https://github.com/apache/arrow/pull/34654

   Adds Python bindings for the OrderByNode added in https://github.com/apache/arrow/pull/34249 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] jorisvandenbossche merged pull request #34654: GH-34248: [Python] Expose the order_by node

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #34654:
URL: https://github.com/apache/arrow/pull/34654


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #34654: GH-34248: [Python] Expose the order_by node

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34654:
URL: https://github.com/apache/arrow/pull/34654#issuecomment-1477494326

   * Closes: #34248


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] jorisvandenbossche commented on pull request #34654: GH-34248: [Python] Expose the order_by node

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #34654:
URL: https://github.com/apache/arrow/pull/34654#issuecomment-1479556570

   > I am a bit unsure about the reason for the change in `CSortKey` class though. This class was only used in `Select*`, `Rank*` and `SortOptions` where, I guess, a field reference could have only been a string column name.
   
   Yeah, this was actually changed a while ago in C++, but the cython bindings exposing it as ``CSortKey(c_string name, ..)`` still worked fine because there is an implicit conversion from string to FieldRef possible. 
   For this PR however, I needed to create a SortKey from a FieldRef (to be consistent with the rest of the node options), and so I needed to update the constructor  to  ``CSortKey(CFieldRef ..)``, which also meant updating it in the other places. 
   
   > Then, I think, this should also be added in the docstrings for other classes that use sort_keys and add this cases to the tests? (maybe not as a part of this PR)
   
   Good point. Updated the docstrings and tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #34654: GH-34248: [Python] Expose the order_by node

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34654:
URL: https://github.com/apache/arrow/pull/34654#issuecomment-1479927174

   Benchmark runs are scheduled for baseline = 928827515bfbd99060d04ccb754646a76a20f7ec and contender = 532b9a57cab4fa1f88438fd0bd79cb7eb8aa2df3. 532b9a57cab4fa1f88438fd0bd79cb7eb8aa2df3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/af3110165ecc42138e86e63721281c1b...ea479eb951294945bdf1e4dcb76b7c64/)
   [Finished :arrow_down:0.3% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5560d9765694bacb6ab3fdf3d2b0154...1c52b10d13534b1dac813100ce75c7de/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d514336ddbe64e30a6287162229d8485...92f9cd717f7a4a6e98d24261bcbcfba5/)
   [Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d08259ded50f4952923e119904e22c36...c2818ce1293342f5984958ec959cdc82/)
   Buildkite builds:
   [Finished] [`532b9a57` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2554)
   [Finished] [`532b9a57` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2584)
   [Finished] [`532b9a57` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2552)
   [Finished] [`532b9a57` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2575)
   [Finished] [`92882751` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2553)
   [Finished] [`92882751` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2583)
   [Finished] [`92882751` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2551)
   [Finished] [`92882751` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2574)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #34654: GH-34248: [Python] Expose the order_by node

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34654:
URL: https://github.com/apache/arrow/pull/34654#issuecomment-1479928611

   ['Python', 'R'] benchmarks have high level of regressions.
   [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5560d9765694bacb6ab3fdf3d2b0154...1c52b10d13534b1dac813100ce75c7de/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org