You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 07:38:19 UTC

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/
-----------------------------------------------------------

(Updated Feb. 5, 2019, 7:38 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
-------

Rebased.


Bugs: MESOS-9537
    https://issues.apache.org/jira/browse/MESOS-9537


Repository: mesos


Description
-------

This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
to use the v1 scheduler API to request operation feedbacks, so
MESOS-9537 would be triggered when an outstanding `UPDATE_STATE` call
from the resource provider races with an offer operation.


Diffs (updated)
-----

  src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550 
  src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377 


Diff: https://reviews.apache.org/r/69866/diff/3/

Changes: https://reviews.apache.org/r/69866/diff/2-3/


Testing
-------

`make check`

Ran the test ~1000 times.

This test will fail without r/69858:
```
E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
...
../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
      Expected: v1::OPERATION_FINISHED
      Which is: OPERATION_FINISHED
To be equal to: update->status().state()
      Which is: OPERATION_ERROR
../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
Failed to wait 15secs for offers
...
../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
```


Thanks,

Chun-Hung Hsiao


Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/#review212735
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 18 (patched)
<https://reviews.apache.org/r/69866/#comment298612>

    Only tangentially related to the changes here, but LGTM.
    
    If we do this we should also explicitly pull in the headers for other used symbols from `std`, e.g., `list`, `string` and `vector`.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1110-1112 (patched)
<https://reviews.apache.org/r/69866/#comment298613>

    Let's use `create` and `remove` in 1, 2, 3, also to be consistent with 4.


- Benjamin Bannier


On Feb. 12, 2019, 6:01 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69866/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9537
>     https://issues.apache.org/jira/browse/MESOS-9537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
> to use the v1 scheduler API to request operation feedback, so MESOS-9537
> would be triggered when an outstanding `UPDATE_STATE` call from the
> resource provider races with an offer operation.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp b10ec0ad62efa8980ca12693939970c2252ee814 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a 
> 
> 
> Diff: https://reviews.apache.org/r/69866/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Ran the test ~1000 times.
> 
> This test will fail without r/69858:
> ```
> E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
> I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
>       Expected: v1::OPERATION_FINISHED
>       Which is: OPERATION_FINISHED
> To be equal to: update->status().state()
>       Which is: OPERATION_ERROR
> ../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
> Failed to wait 15secs for offers
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
> Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
>          Expected: to be called once
>            Actual: never called - unsatisfied and active
> ```
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/
-----------------------------------------------------------

(Updated Feb. 13, 2019, 3:08 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
-------

Fixed a compilation error.


Bugs: MESOS-9537
    https://issues.apache.org/jira/browse/MESOS-9537


Repository: mesos


Description
-------

This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
to use the v1 scheduler API to request operation feedback, so MESOS-9537
would be triggered when an outstanding `UPDATE_STATE` call from the
resource provider races with an offer operation.


Diffs (updated)
-----

  src/tests/mesos.hpp b10ec0ad62efa8980ca12693939970c2252ee814 
  src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a 


Diff: https://reviews.apache.org/r/69866/diff/7/

Changes: https://reviews.apache.org/r/69866/diff/6-7/


Testing
-------

`make check`

Ran the test ~1000 times.

This test will fail without r/69858:
```
E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
...
../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
      Expected: v1::OPERATION_FINISHED
      Which is: OPERATION_FINISHED
To be equal to: update->status().state()
      Which is: OPERATION_ERROR
../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
Failed to wait 15secs for offers
...
../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
```


Thanks,

Chun-Hung Hsiao


Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/
-----------------------------------------------------------

(Updated Feb. 12, 2019, 8:41 p.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9537
    https://issues.apache.org/jira/browse/MESOS-9537


Repository: mesos


Description
-------

This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
to use the v1 scheduler API to request operation feedback, so MESOS-9537
would be triggered when an outstanding `UPDATE_STATE` call from the
resource provider races with an offer operation.


Diffs (updated)
-----

  src/tests/mesos.hpp b10ec0ad62efa8980ca12693939970c2252ee814 
  src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a 


Diff: https://reviews.apache.org/r/69866/diff/6/

Changes: https://reviews.apache.org/r/69866/diff/5-6/


Testing
-------

`make check`

Ran the test ~1000 times.

This test will fail without r/69858:
```
E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
...
../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
      Expected: v1::OPERATION_FINISHED
      Which is: OPERATION_FINISHED
To be equal to: update->status().state()
      Which is: OPERATION_ERROR
../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
Failed to wait 15secs for offers
...
../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
```


Thanks,

Chun-Hung Hsiao


Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/
-----------------------------------------------------------

(Updated Feb. 12, 2019, 5:01 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
-------

Rebased.


Bugs: MESOS-9537
    https://issues.apache.org/jira/browse/MESOS-9537


Repository: mesos


Description
-------

This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
to use the v1 scheduler API to request operation feedback, so MESOS-9537
would be triggered when an outstanding `UPDATE_STATE` call from the
resource provider races with an offer operation.


Diffs (updated)
-----

  src/tests/mesos.hpp b10ec0ad62efa8980ca12693939970c2252ee814 
  src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a 


Diff: https://reviews.apache.org/r/69866/diff/5/

Changes: https://reviews.apache.org/r/69866/diff/4-5/


Testing
-------

`make check`

Ran the test ~1000 times.

This test will fail without r/69858:
```
E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
...
../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
      Expected: v1::OPERATION_FINISHED
      Which is: OPERATION_FINISHED
To be equal to: update->status().state()
      Which is: OPERATION_ERROR
../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
Failed to wait 15secs for offers
...
../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
```


Thanks,

Chun-Hung Hsiao


Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/
-----------------------------------------------------------

(Updated Feb. 6, 2019, 12:05 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
-------

Addressed Benjamin's comments.


Summary (updated)
-----------------

Updated SLRP test `ProfileDisappeared` to request operation feedback.


Bugs: MESOS-9537
    https://issues.apache.org/jira/browse/MESOS-9537


Repository: mesos


Description (updated)
-------

This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
to use the v1 scheduler API to request operation feedback, so MESOS-9537
would be triggered when an outstanding `UPDATE_STATE` call from the
resource provider races with an offer operation.


Diffs (updated)
-----

  src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550 
  src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377 


Diff: https://reviews.apache.org/r/69866/diff/4/

Changes: https://reviews.apache.org/r/69866/diff/3-4/


Testing
-------

`make check`

Ran the test ~1000 times.

This test will fail without r/69858:
```
E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
...
../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
      Expected: v1::OPERATION_FINISHED
      Which is: OPERATION_FINISHED
To be equal to: update->status().state()
      Which is: OPERATION_ERROR
../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
Failed to wait 15secs for offers
...
../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
```


Thanks,

Chun-Hung Hsiao


Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

Posted by Chun-Hung Hsiao <ch...@apache.org>.

> On Feb. 5, 2019, 12:07 p.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 1342-1343 (original), 1391-1392 (patched)
> > <https://reviews.apache.org/r/69866/diff/3/?file=2123912#file2123912line1430>
> >
> >     This seems weird as `UpdateSlaveMessages` should only be triggered for speculation failures and `DESTROY_DISK` should never be speculated.
> >     
> >     Don't we see the update due to the profile changes (which triggered a storage pool reconciliation)?

Hmm I'm skipping some important details. It should be that `DESTROY_DISK` on a disappeared profile triggers a reconciliation, which in turns triggers a an update. However this is too implementation-specific and might change, so let me make the comment more generic.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/#review212545
-----------------------------------------------------------


On Feb. 5, 2019, 7:38 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69866/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2019, 7:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9537
>     https://issues.apache.org/jira/browse/MESOS-9537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
> to use the v1 scheduler API to request operation feedbacks, so
> MESOS-9537 would be triggered when an outstanding `UPDATE_STATE` call
> from the resource provider races with an offer operation.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550 
>   src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377 
> 
> 
> Diff: https://reviews.apache.org/r/69866/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Ran the test ~1000 times.
> 
> This test will fail without r/69858:
> ```
> E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
> I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
>       Expected: v1::OPERATION_FINISHED
>       Which is: OPERATION_FINISHED
> To be equal to: update->status().state()
>       Which is: OPERATION_ERROR
> ../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
> Failed to wait 15secs for offers
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
> Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
>          Expected: to be called once
>            Actual: never called - unsatisfied and active
> ```
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/#review212545
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Line 1166 (original), 1178 (patched)
<https://reviews.apache.org/r/69866/#comment298354>

    `s/feedbacks/feedback/g`.
    
    Here and everywhere else.



src/tests/storage_local_resource_provider_tests.cpp
Line 1288 (original), 1318 (patched)
<https://reviews.apache.org/r/69866/#comment298355>

    `s/Creates/Create/`



src/tests/storage_local_resource_provider_tests.cpp
Lines 1342-1343 (original), 1391-1392 (patched)
<https://reviews.apache.org/r/69866/#comment298356>

    This seems weird as `UpdateSlaveMessages` should only be triggered for speculation failures and `DESTROY_DISK` should never be speculated.
    
    Don't we see the update due to the profile changes (which triggered a storage pool reconciliation)?


- Benjamin Bannier


On Feb. 5, 2019, 8:38 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69866/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2019, 8:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9537
>     https://issues.apache.org/jira/browse/MESOS-9537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
> to use the v1 scheduler API to request operation feedbacks, so
> MESOS-9537 would be triggered when an outstanding `UPDATE_STATE` call
> from the resource provider races with an offer operation.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550 
>   src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377 
> 
> 
> Diff: https://reviews.apache.org/r/69866/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Ran the test ~1000 times.
> 
> This test will fail without r/69858:
> ```
> E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
> I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
>       Expected: v1::OPERATION_FINISHED
>       Which is: OPERATION_FINISHED
> To be equal to: update->status().state()
>       Which is: OPERATION_ERROR
> ../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
> Failed to wait 15secs for offers
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
> Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1, "test2"))))...
>          Expected: to be called once
>            Actual: never called - unsatisfied and active
> ```
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>