You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/02 13:10:53 UTC

[GitHub] [camel-website] AemieJ commented on a change in pull request #444: CAMEL-15335: update the search layout design

AemieJ commented on a change in pull request #444:
URL: https://github.com/apache/camel-website/pull/444#discussion_r464077068



##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -390,15 +410,45 @@ body {
   padding-right: 0.5rem;
 }
 
+#search_results div.result {
+  padding: 0.25rem;
+  pointer-events: none;
+}
+
+#search_results div.result:hover {
+  background: var(--color-smoke-50);
+}
+
+#search_results div.section {
+  display: flex;
+}
+

Review comment:
       This doesn't remove scrollbars necessarily. Scrollbars only appear when the text covered by dl has height > 80vh which occurs in a few cases. Hence, I suggested using pagination to avoid scrollbars usage. However, for this PR, I wanted to just have a basic implementation for the search design layout.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org