You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/08/18 00:51:18 UTC
Review Request 37558: Updated Proto <-> JSON conversion to use base64
for 'bytes' fields.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37558/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3284
https://issues.apache.org/jira/browse/MESOS-3284
Repository: mesos
Description
-------
See MESOS-3284 for context.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 82eae873b9f0d5a7232085282f35b0f22dcd891d
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 2b98945a08f7bbf60967cf8d1c7e5970096c05bd
Diff: https://reviews.apache.org/r/37558/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 37558: Updated Proto <-> JSON conversion to use
base64 for 'bytes' fields.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37558/#review95660
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 17, 2015, 10:51 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37558/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2015, 10:51 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3284
> https://issues.apache.org/jira/browse/MESOS-3284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3284 for context.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 82eae873b9f0d5a7232085282f35b0f22dcd891d
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 2b98945a08f7bbf60967cf8d1c7e5970096c05bd
>
> Diff: https://reviews.apache.org/r/37558/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>