You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:40:35 UTC

[GitHub] [incubator-mxnet] grygielski opened a new pull request #19466: [BUGFIX] Fallback to native implementation of RNN when use_sequence_length=True

grygielski opened a new pull request #19466:
URL: https://github.com/apache/incubator-mxnet/pull/19466


   ## Description ##
   This PR is addressing https://github.com/apache/incubator-mxnet/issues/19323. I've added additional check for `use_sequence_length` parameter when choosing kernel to run. oneDNN does not support variable sequence length so the code right now raises an error.
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [x] Fallback to native RNN implementation when `use_sequence_length` parameter is set to `true`
   
   ## Comments ##
   - No further comments from my side.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on pull request #19466: [BUGFIX] Fallback to native implementation of RNN when use_sequence_length=True

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19466:
URL: https://github.com/apache/incubator-mxnet/pull/19466#issuecomment-720590654


   @mxnet-bot run ci [windows-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu merged pull request #19466: [BUGFIX] Fallback to native implementation of RNN when use_sequence_length=True

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19466:
URL: https://github.com/apache/incubator-mxnet/pull/19466


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] grygielski commented on pull request #19466: [BUGFIX] Fallback to native implementation of RNN when use_sequence_length=True

Posted by GitBox <gi...@apache.org>.
grygielski commented on pull request #19466:
URL: https://github.com/apache/incubator-mxnet/pull/19466#issuecomment-720468161






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19466: [BUGFIX] Fallback to native implementation of RNN when use_sequence_length=True

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19466:
URL: https://github.com/apache/incubator-mxnet/pull/19466#issuecomment-720467548






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org