[GitHub] [pulsar] eolivelli commented on a change in pull request #10697: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-common`

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #10697:
URL: https://github.com/apache/pulsar/pull/10697#discussion_r638726107



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/NonPersistentPublisherStats.java
##########
@@ -31,7 +29,9 @@
     public double msgDropRate;
 
     public NonPersistentPublisherStats add(NonPersistentPublisherStats stats) {
-        checkNotNull(stats);

Review comment:
       there is Objects.requireNonNull in the JDK, we replace Preconditions with Objects

##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/FunctionStats.java
##########
@@ -18,25 +18,17 @@
  */
 package org.apache.pulsar.common.policies.data;
 
-import com.fasterxml.jackson.annotation.JsonInclude;
-import com.fasterxml.jackson.annotation.JsonProperty;
-import com.fasterxml.jackson.annotation.JsonPropertyOrder;
-import java.io.IOException;
 import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 import lombok.Data;
 import lombok.EqualsAndHashCode;
-import org.apache.pulsar.common.util.ObjectMapperFactory;
 
 /**
  * Statistics for Pulsar Function.
  */
 @Data
-@JsonInclude(JsonInclude.Include.ALWAYS)
-@JsonPropertyOrder({"receivedTotal", "processedSuccessfullyTotal", "systemExceptionsTotal", "userExceptionsTotal",

Review comment:
       is this removal changing the final output of the JSON encoded version of this structure ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org