[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on a change in pull request #200: [YUNIKORN-421] Define app gang scheduling info in API package.

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #200:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/200#discussion_r511602817



##########
File path: test/e2e/testdata/application.yaml
##########
@@ -24,9 +24,11 @@ spec:
     name: TryOnce
   queue: root.default
   taskGroups:
-    - groupName: "test-task-0001"
-      minMember: 1
-      minResource:
-        cpu: "300m"
-        memory: "128Mi"
+    - schedulingPolicy: "TryReserve"
+    - groups:

Review comment:
       I liked better the previous structure of having just taskGroups field instead of having taskGroups, than groups. For me it seems redundant to have both fields. Can you please explain why it is better this structure than the previous one?

##########
File path: test/e2e/app/app_test.go
##########
@@ -74,14 +74,14 @@ var _ = ginkgo.Describe("App", func() {
 			gomega.Ω(appCRD.Spec.Queue).To(gomega.Equal("root.default"))
 			gomega.Ω(appCRD.ObjectMeta.Name).To(gomega.Equal("example"))
 			gomega.Ω(appCRD.ObjectMeta.Namespace).To(gomega.Equal(dev))
-			policy := appCRD.Spec.Policy.Policy
-			gomega.Ω(string(policy)).To(gomega.Equal("TryOnce"))
-			gomega.Ω(appCRD.Spec.TaskGroup[0].GroupName).To(gomega.Equal("test-task-0001"))
-			gomega.Ω(appCRD.Spec.TaskGroup[0].MinMember).To(gomega.Equal(int32(1)))
+			policy := appCRD.Spec.TaskGroups.SchedulingPolicy
+			gomega.Ω(policy.Type).To(gomega.Equal("TryReserve"))

Review comment:
       Please use the TryReserve constant defined for the policy type.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org