You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/14 01:16:00 UTC

[jira] [Work logged] (BEAM-3847) Remove the rich wrapper from EnvironmentManager

     [ https://issues.apache.org/jira/browse/BEAM-3847?focusedWorklogId=80165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-80165 ]

ASF GitHub Bot logged work on BEAM-3847:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/18 01:15
            Start Date: 14/Mar/18 01:15
    Worklog Time Spent: 10m 
      Work Description: tgroh opened a new pull request #4866: [BEAM-3847] Use InstructionRequestHandler in RemoteEnvironment
URL: https://github.com/apache/beam/pull/4866
 
 
   This separates the need to construct the rich client, instead allowing
   callers to wrap with their own rich wrapper as appropriate.
   
   ------------------------
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand:
      - [ ] What the pull request does
      - [ ] Why it does it
      - [ ] How it does it
      - [ ] Why this approach
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 80165)
            Time Spent: 10m
    Remaining Estimate: 0h

> Remove the rich wrapper from EnvironmentManager
> -----------------------------------------------
>
>                 Key: BEAM-3847
>                 URL: https://issues.apache.org/jira/browse/BEAM-3847
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>            Priority: Major
>              Labels: portability
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The current wrapper couples the rich implementation of the Control Plane instead of wrapping the simplest possible wrapper. Using the simple client is preferable, as it permits more sophisticated users to enrich the client directly, and the additional complexity required for other users is almost nonexistent (it consists of one additional call, with access to a DataService, and can be wrapped around an EnvironmentManager wrapper)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)