You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/08 02:45:21 UTC

[jira] [Commented] (METRON-203) Coding best-practice fixes

    [ https://issues.apache.org/jira/browse/METRON-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319884#comment-15319884 ] 

ASF GitHub Bot commented on METRON-203:
---------------------------------------

GitHub user mmiklavc opened a pull request:

    https://github.com/apache/incubator-metron/pull/146

    METRON-203 General best practice and bug fixes

    https://issues.apache.org/jira/browse/METRON-203
    
    Fixed:
    - Boolean.getBoolean() usage issues.
    - Potential NPE problems
    - equals/hashcode usage

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mmiklavc/incubator-metron METRON-203-merge

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #146
    
----
commit 7dbf128118233b1da89c2a131c80773c3a3739cb
Author: Michael Miklavcic <mi...@gmail.com>
Date:   2016-06-06T20:03:27Z

    METRON-203 General best practice and bug fixes

----


> Coding best-practice fixes
> --------------------------
>
>                 Key: METRON-203
>                 URL: https://issues.apache.org/jira/browse/METRON-203
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>
> Bucket for correcting bad null handling, exception handling, and other Java API mistakes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)