You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Masahiro Tanaka <ta...@oss.nttdata.com> on 2017/01/10 05:23:47 UTC

Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55369/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako.

Bugs: AMBARI-19415
https://issues.apache.org/jira/browse/AMBARI-19415

Repository: ambari

Description
-------

Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command.

A warning like below (which is in ambari-agent.log) is because of the assumption.
```
WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from
```

It would be better to check the NIC with `ifconfig` and `ip` both for better coverage.

Diffs
-----

ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7
ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b

Diff: https://reviews.apache.org/r/55369/diff/

Testing
-------

Hadoop QA added a comment - 13 hours ago

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in ambari-agent.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console

This message is automatically generated.

Thanks,

Masahiro Tanaka

Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

Posted by Masahiro Tanaka <ta...@oss.nttdata.com>.


> On Jan. 11, 2017, 3:37 a.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/Facter.py, line 400
> > <https://reviews.apache.org/r/55369/diff/1/?file=1600539#file1600539line400>
> >
> >     Add documentation to these 2 functions

Thanks you for reviewing my patch! You mean, `setDataIplinkOutput` and `setDataIfConfigOutput` function like below?

```
  # Returns `ip link` output
  @staticmethod
  def setDataIpLinkOutput():

    try:
      result = os.popen(FacterLinux.GET_IP_LINK_CMD).read()
      return result
    except OSError:
      log.warn("Can't execute {0}".format(FacterLinux.GET_IP_LINK_CMD))
    return ""
```


- Masahiro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55369/#review161098
-----------------------------------------------------------


On Jan. 10, 2017, 2:23 p.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55369/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2017, 2:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19415
>     https://issues.apache.org/jira/browse/AMBARI-19415
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command. 
> 
> A warning like below (which is in ambari-agent.log) is because of the assumption.
> ```
> WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from
> ```
> 
> It would be better to check the NIC with `ifconfig` and `ip` both for  better coverage.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7 
>   ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b 
> 
> Diff: https://reviews.apache.org/r/55369/diff/
> 
> 
> Testing
> -------
> 
> Hadoop QA added a comment - 13 hours ago
> 
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> +1 tests included. The patch appears to include 1 new or modified test files.
> 
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> 
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-agent.
> 
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55369/#review161098
-----------------------------------------------------------


Fix it, then Ship it!





ambari-agent/src/main/python/ambari_agent/Facter.py (line 400)
<https://reviews.apache.org/r/55369/#comment232333>

    Add documentation to these 2 functions



ambari-agent/src/main/python/ambari_agent/Facter.py (line 505)
<https://reviews.apache.org/r/55369/#comment232332>

    Add a comment as to why this was needed


- Alejandro Fernandez


On Jan. 10, 2017, 5:23 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55369/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19415
>     https://issues.apache.org/jira/browse/AMBARI-19415
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command. 
> 
> A warning like below (which is in ambari-agent.log) is because of the assumption.
> ```
> WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from
> ```
> 
> It would be better to check the NIC with `ifconfig` and `ip` both for  better coverage.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7 
>   ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b 
> 
> Diff: https://reviews.apache.org/r/55369/diff/
> 
> 
> Testing
> -------
> 
> Hadoop QA added a comment - 13 hours ago
> 
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> +1 tests included. The patch appears to include 1 new or modified test files.
> 
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> 
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-agent.
> 
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

Posted by Yusaku Sako <yu...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55369/#review162562
-----------------------------------------------------------


Ship it!




Ship It!

- Yusaku Sako


On Jan. 16, 2017, 3:34 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55369/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 3:34 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19415
>     https://issues.apache.org/jira/browse/AMBARI-19415
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command. 
> 
> A warning like below (which is in ambari-agent.log) is because of the assumption.
> ```
> WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from
> ```
> 
> It would be better to check the NIC with `ifconfig` and `ip` both for  better coverage.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7 
>   ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b 
> 
> Diff: https://reviews.apache.org/r/55369/diff/
> 
> 
> Testing
> -------
> 
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12847494/AMBARI-19415.1.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> +1 tests included. The patch appears to include 1 new or modified test files.
> 
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> 
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-agent.
> 
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10063//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10063//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

Posted by Masahiro Tanaka <ta...@oss.nttdata.com>.

(Updated 1\u6708 16, 2017, 12:34 p.m.)

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako.

Bugs: AMBARI-19415
https://issues.apache.org/jira/browse/AMBARI-19415

Repository: ambari

Description
-------

Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command.

A warning like below (which is in ambari-agent.log) is because of the assumption.
```
WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from
```

It would be better to check the NIC with `ifconfig` and `ip` both for better coverage.

Diffs
-----

ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7
ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b

Diff: https://reviews.apache.org/r/55369/diff/

Testing (updated)
-------

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12847494/AMBARI-19415.1.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in ambari-agent.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/10063//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/10063//console

This message is automatically generated.

Thanks,

Masahiro Tanaka

Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

Posted by Masahiro Tanaka <ta...@oss.nttdata.com>.

(Updated 1\u6708 16, 2017, 12:33 p.m.)

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, Sebastian Toader, and Yusaku Sako.

Bugs: AMBARI-19415
https://issues.apache.org/jira/browse/AMBARI-19415

Repository: ambari

Description
-------

Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but some environments (e.g. CentOS 7.3 with minimal install) doens't have `ifconfig` command, but `ip` command.

A warning like below (which is in ambari-agent.log) is because of the assumption.
```
WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network interfaces list from
```

It would be better to check the NIC with `ifconfig` and `ip` both for better coverage.

Diffs (updated)
-----

ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7
ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b

Diff: https://reviews.apache.org/r/55369/diff/

Testing
-------

Hadoop QA added a comment - 13 hours ago

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in ambari-agent.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console

This message is automatically generated.

Thanks,

Masahiro Tanaka