You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/07/05 10:02:06 UTC
[GitHub] incubator-weex pull request #494: + [android] add scroll event on horizontal...
GitHub user misakuo opened a pull request:
https://github.com/apache/incubator-weex/pull/494
+ [android] add scroll event on horizontal scroller
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/misakuo/incubator-weex android-feature-horizontal-scroll-event
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #494
----
commit 1b443882968d5d26f95c7480ac06b3f0dd2097ea
Author: misakuo <mi...@apache.org>
Date: 2017-07-05T10:01:14Z
+ [android] add scroll event on horizontal scroller
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #494: + [android] add scroll event on horizontal scroll...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/494
<!--
1 failure: This PR modify SD...
3 warning: No Changelog chan..., This PR should up..., Potential BREAK C...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @luics , @zshshr to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #494: + [android] add scroll event on horizontal...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/494
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---