You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ilya Borisov (JIRA)" <ji...@apache.org> on 2019/01/25 11:00:01 UTC
[jira] [Commented] (IGNITE-9879) Web console: split major features
to modules - configuration
[ https://issues.apache.org/jira/browse/IGNITE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752151#comment-16752151 ]
Ilya Borisov commented on IGNITE-9879:
--------------------------------------
All done. About 130kb out of 1.04Mb JS bundle (gzipped) are now loaded lazily. I also converted most of configuration module files to TypeScript.
> Web console: split major features to modules - configuration
> ------------------------------------------------------------
>
> Key: IGNITE-9879
> URL: https://issues.apache.org/jira/browse/IGNITE-9879
> Project: Ignite
> Issue Type: Improvement
> Components: wizards
> Reporter: Ilya Borisov
> Assignee: Ilya Borisov
> Priority: Minor
> Original Estimate: 16h
> Time Spent: 7h
> Remaining Estimate: 9h
>
> The issue:
> 1. _app.js_ is massive, hard to maintain and often a source of various merge conflicts.
> 2. Even if some code is de facto separated by feature (configuration/queries/admin/profile), no agreement was made on how to structure directories, which leads to confusion and app.js growth.
> I propose to:
> 1. Reorganize source code file structure:
> {noformat}
> frontend
> app
> configuration
> queries
> profile
> admin
> common
> {noformat}
> 2. Slim _app.js_ down to something like this:
> {noformat}
> import common from './common'
> import configuration from './configuration'
> import queries from './queries'
> import profile from './profile'
> import admin from './admin'
> export default angular.module('ignite-console', [
> common.name,
> configuration.name,
> queries.name,
> profile.name,
> admin.name
> ])
> {noformat}
> Each directory inside app will follow the same module structure as agreed upon before (i.e. components/services/filters, etc).
> 3. In order to test water, update the configuration module first and if everything goes as expect proceed with other modules.
> [~kuaw26], [~anovikov] what do you think?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)