[GitHub] [pulsar] eolivelli commented on a change in pull request #9500: Optimize built-in source/sink startup Part 2

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9500:
URL: https://github.com/apache/pulsar/pull/9500#discussion_r571378547



##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntime.java
##########
@@ -145,6 +204,12 @@ public void stop() {
             }
             // make sure JavaInstanceRunnable is closed
             this.javaInstanceRunnable.close();
+
+            // once the thread quits, clean up the instance
+            fnCache.unregisterFunctionInstance(
+                    instanceConfig.getFunctionId(),
+                    instanceConfig.getInstanceName());
+            log.info("Unloading JAR files for function {}", instanceConfig);

Review comment:
       Do we have to move this line one line above?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org