[jira] [Commented] (NIFI-5073) JMSConnectionFactory doesn't resolve 'variables' properly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452929#comment-16452929 ] 

ASF GitHub Bot commented on NIFI-5073:
--------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2653#discussion_r184179013
  
    --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java ---
    @@ -97,7 +96,7 @@
                 .description("Path to the directory with additional resources (i.e., JARs, configuration files etc.) to be added "
                         + "to the classpath. Such resources typically represent target MQ client libraries for the "
                         + "ConnectionFactory implementation.")
    -            .addValidator(new ClientLibValidator())
    +            .addValidator(StandardValidators.createListValidator(true, true, StandardValidators.createURLorFileValidator()))
    --- End diff --
    
    I don't think this is the proper validation here. Changing it to support a list of files/directories/urls is probably a good idea. However, at present this processor expects that the configured value be a directory. I think we need to either update the processor to accept the list, or otherwise just use `StandardValidators.createDirectoryExistsValidator(true, false);`


> JMSConnectionFactory doesn't resolve 'variables' properly
> ---------------------------------------------------------
>
>                 Key: NIFI-5073
>                 URL: https://issues.apache.org/jira/browse/NIFI-5073
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Matthew Clarke
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Major
>         Attachments: 0001-NIFI-5073-JMSConnectionFactoryProvider-now-resolves-.patch
>
>
> Create a new process Group.
> Add "Variables" to the process group:
> for example:
> broker_uri=tcp://localhost:4141
> client_libs=/NiFi/custom-lib-dir/MQlib
> con_factory=blah
> Then while that process group is selected, create  a controller service.
> Create JMSConnectionFactory.
> Configure this controller service to use EL for PG defined variables above:
> ${con_factory}, ${con_factory}, and ${broker_uri}
> The controller service will remain invalid because the EL statements are not properly resolved to their set values.
> Doing the exact same thing above using the external NiFi registry file works as expected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)