You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/22 09:58:31 UTC

[GitHub] [spark] MaxGekk opened a new pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

MaxGekk opened a new pull request #31610:
URL: https://github.com/apache/spark/pull/31610


   ### What changes were proposed in this pull request?
   In the PR, I propose to revert https://github.com/apache/spark/pull/26659 partially regarding to comparability of interval values. The comment became incorrect after https://github.com/apache/spark/pull/27262.
   
   ### Why are the changes needed?
   To comment is incorrect, and it might confuse Spark's devs/users.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By checking scala coding style `./dev/scalastyle`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783371444


   thanks, merging to master/3.1!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31610:
URL: https://github.com/apache/spark/pull/31610


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783270065


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783273413


   **[Test build #135342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135342/testReport)** for PR 31610 at commit [`67ce1f5`](https://github.com/apache/spark/commit/67ce1f523cc448ae46e59e78633a7d1232ae4963).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783332427


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39922/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783251094


   @yaooqinn @cloud-fan Could you take a look at this minor fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783429707


   **[Test build #135342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135342/testReport)** for PR 31610 at commit [`67ce1f5`](https://github.com/apache/spark/commit/67ce1f523cc448ae46e59e78633a7d1232ae4963).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783332427


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39922/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783446245


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135342/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783446245


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135342/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31610: [MINOR][SQL] Fix the comment for CalendarIntervalType about comparability.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31610:
URL: https://github.com/apache/spark/pull/31610#issuecomment-783273413


   **[Test build #135342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135342/testReport)** for PR 31610 at commit [`67ce1f5`](https://github.com/apache/spark/commit/67ce1f523cc448ae46e59e78633a7d1232ae4963).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org