You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/01 11:41:20 UTC
[GitHub] [spark] beliefer opened a new pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
beliefer opened a new pull request #28430:
URL: https://github.com/apache/spark/pull/28430
### What changes were proposed in this pull request?
This PR follows up https://github.com/apache/spark/pull/28194.
As discussed at https://github.com/apache/spark/pull/28194/files#r418418796.
This PR will improve `ExpressionsSchemaSuite` so that easy to track the diff.
Although `ExpressionsSchemaSuite` at line
https://github.com/apache/spark/blob/b7cde42b04b21c9bfee6535199cf385855c15853/sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala#L165
just want to compare the total size between expected output size and the newest output size, the scalatest framework will output the extra information contains all the content of expected output and newest output.
This PR will try to avoid this issue.
### Why are the changes needed?
Make the exception more concise and clear.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
Jenkins test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623317754
**[Test build #122257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122257/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622478484
**[Test build #122173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122173/testReport)** for PR 28430 at commit [`bf7f621`](https://github.com/apache/spark/commit/bf7f621552a1aea0687616d023982a8cfdd66816).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623337870
**[Test build #122257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122257/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623365466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623317754
**[Test build #122257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122257/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622355883
cc @HyukjinKwon @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622374749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622374267
**[Test build #122173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122173/testReport)** for PR 28430 at commit [`bf7f621`](https://github.com/apache/spark/commit/bf7f621552a1aea0687616d023982a8cfdd66816).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28430:
URL: https://github.com/apache/spark/pull/28430#discussion_r419183476
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -156,14 +156,16 @@ class ExpressionsSchemaSuite extends QueryTest with SharedSparkSession {
stringToFile(resultFile, goldenOutput)
}
+ val outputSize = outputs.size
val expectedOutputs: Seq[QueryOutput] = {
- val goldenOutput = fileToString(resultFile)
- val lines = goldenOutput.split("\n")
+ val expectedGoldenOutput = fileToString(resultFile)
+ val lines = expectedGoldenOutput.split("\n")
+ val expectedSize = lines.size
// The header of golden file has one line, plus four lines of the summary and three
// lines of the header of schema table.
- assert(lines.size == outputs.size + 8,
- s"Expected ${outputs.size + 8} blocks in result file but got ${lines.size}. " +
+ assert(expectedSize == outputSize + 8,
Review comment:
@beliefer, can we have one string variable to keep the summary and header lines, and calculate the number (`8`) of extra lines from the variable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623364914
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623295155
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122240/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623368348
**[Test build #122261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122261/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623516083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623316506
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622356163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622356163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623251869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622479387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623337976
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623813026
@HyukjinKwon Thanks for your help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622457666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622456850
**[Test build #122171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122171/testReport)** for PR 28430 at commit [`d4e50d6`](https://github.com/apache/spark/commit/d4e50d6e92c24b98f4d671ff7d1cc38d58e60f80).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622457666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623294828
**[Test build #122240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122240/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28430:
URL: https://github.com/apache/spark/pull/28430#discussion_r419183476
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -156,14 +156,16 @@ class ExpressionsSchemaSuite extends QueryTest with SharedSparkSession {
stringToFile(resultFile, goldenOutput)
}
+ val outputSize = outputs.size
val expectedOutputs: Seq[QueryOutput] = {
- val goldenOutput = fileToString(resultFile)
- val lines = goldenOutput.split("\n")
+ val expectedGoldenOutput = fileToString(resultFile)
+ val lines = expectedGoldenOutput.split("\n")
+ val expectedSize = lines.size
// The header of golden file has one line, plus four lines of the summary and three
// lines of the header of schema table.
- assert(lines.size == outputs.size + 8,
- s"Expected ${outputs.size + 8} blocks in result file but got ${lines.size}. " +
+ assert(expectedSize == outputSize + 8,
Review comment:
@beliefer, can we have one string variable to keep the summary and header lines, and calculate the number of extra lines from the variable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623295146
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623514753
**[Test build #122261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122261/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623318306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622374749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623368348
**[Test build #122261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122261/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623318306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623337983
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122257/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622479387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623786752
Merged to master and branc-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623295146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623251556
**[Test build #122240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122240/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623251869
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622374267
**[Test build #122173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122173/testReport)** for PR 28430 at commit [`bf7f621`](https://github.com/apache/spark/commit/bf7f621552a1aea0687616d023982a8cfdd66816).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623365466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623516083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28430:
URL: https://github.com/apache/spark/pull/28430#discussion_r419209216
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##########
@@ -156,14 +156,16 @@ class ExpressionsSchemaSuite extends QueryTest with SharedSparkSession {
stringToFile(resultFile, goldenOutput)
}
+ val outputSize = outputs.size
val expectedOutputs: Seq[QueryOutput] = {
- val goldenOutput = fileToString(resultFile)
- val lines = goldenOutput.split("\n")
+ val expectedGoldenOutput = fileToString(resultFile)
+ val lines = expectedGoldenOutput.split("\n")
+ val expectedSize = lines.size
// The header of golden file has one line, plus four lines of the summary and three
// lines of the header of schema table.
- assert(lines.size == outputs.size + 8,
- s"Expected ${outputs.size + 8} blocks in result file but got ${lines.size}. " +
+ assert(expectedSize == outputSize + 8,
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622357628
**[Test build #122171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122171/testReport)** for PR 28430 at commit [`d4e50d6`](https://github.com/apache/spark/commit/d4e50d6e92c24b98f4d671ff7d1cc38d58e60f80).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-622357628
**[Test build #122171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122171/testReport)** for PR 28430 at commit [`d4e50d6`](https://github.com/apache/spark/commit/d4e50d6e92c24b98f4d671ff7d1cc38d58e60f80).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623337976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28430: [SPARK-31372][SQL][TEST][FOLLOW-UP] Improve ExpressionsSchemaSuite so that easy to track the diff.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28430:
URL: https://github.com/apache/spark/pull/28430#issuecomment-623251556
**[Test build #122240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122240/testReport)** for PR 28430 at commit [`951bf24`](https://github.com/apache/spark/commit/951bf24a0d52ce0b84410636b7caeba136c4bf75).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org