You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by du...@apache.org on 2022/02/08 09:54:43 UTC
[rocketmq] branch develop updated: [ISSUE #3797] Improve DefaultMQProducerImpl code (#3809)
This is an automated email from the ASF dual-hosted git repository.
duhengforever pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 810b757 [ISSUE #3797] Improve DefaultMQProducerImpl code (#3809)
810b757 is described below
commit 810b75766b7cd6692f871208aaec43f6132abfe1
Author: Kvicii <42...@users.noreply.github.com>
AuthorDate: Tue Feb 8 17:54:07 2022 +0800
[ISSUE #3797] Improve DefaultMQProducerImpl code (#3809)
* improve DefaultMQProducerImpl code
* revert change
Co-authored-by: Kvicii <Ka...@gmail.com>
---
.../rocketmq/client/impl/producer/DefaultMQProducerImpl.java | 10 +++++-----
.../rocketmq/client/producer/LocalTransactionExecuter.java | 2 +-
.../rocketmq/client/producer/TransactionCheckListener.java | 3 ++-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
index 9afbe9b..f3f9caf 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -283,9 +283,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
}
/**
- * This method will be removed in the version 5.0.0 and <code>getCheckListener</code> is recommended.
- *
- * @return
+ * @deprecated This method will be removed in the version 5.0.0 and {@link DefaultMQProducerImpl#getCheckListener} is recommended.
*/
@Override
@Deprecated
@@ -485,6 +483,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
}
/**
+ * @deprecated
* It will be removed at 4.4.0 cause for exception handling and the wrong Semantics of timeout. A new one will be
* provided in next version
*
@@ -1035,6 +1034,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
}
/**
+ * @deprecated
* It will be removed at 4.4.0 cause for exception handling and the wrong Semantics of timeout. A new one will be
* provided in next version
*
@@ -1193,7 +1193,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
sendSelectImpl(msg, selector, arg, CommunicationMode.ASYNC, sendCallback,
timeout - costTime);
} catch (MQBrokerException e) {
- throw new MQClientException("unknownn exception", e);
+ throw new MQClientException("unknown exception", e);
}
} catch (Exception e) {
sendCallback.onException(e);
@@ -1205,7 +1205,7 @@ public class DefaultMQProducerImpl implements MQProducerInner {
});
} catch (RejectedExecutionException e) {
- throw new MQClientException("exector rejected ", e);
+ throw new MQClientException("executor rejected ", e);
}
}
diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java b/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java
index 28789b9..267ba10 100644
--- a/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java
+++ b/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java
@@ -19,7 +19,7 @@ package org.apache.rocketmq.client.producer;
import org.apache.rocketmq.common.message.Message;
/**
- * This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
+ * @deprecated This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
*/
@Deprecated
public interface LocalTransactionExecuter {
diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/TransactionCheckListener.java b/client/src/main/java/org/apache/rocketmq/client/producer/TransactionCheckListener.java
index 2d7cf58..5f59506 100644
--- a/client/src/main/java/org/apache/rocketmq/client/producer/TransactionCheckListener.java
+++ b/client/src/main/java/org/apache/rocketmq/client/producer/TransactionCheckListener.java
@@ -17,8 +17,9 @@
package org.apache.rocketmq.client.producer;
import org.apache.rocketmq.common.message.MessageExt;
+
/**
- * This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
+ * @deprecated This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
*/
@Deprecated
public interface TransactionCheckListener {