You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/07/11 20:21:51 UTC

[GitHub] [couchdb] noahshaw11 opened a new pull request, #4099: Add filepath to is_compacting

noahshaw11 opened a new pull request, #4099:
URL: https://github.com/apache/couchdb/pull/4099

   ## Overview
   
   When smoosh is checking for compaction files to restore active compaction jobs, it uses the wrong file path. Currently, it looks for `<ShardPath>.{compact, compact.data, compact.meta}` instead of the correct `<ShardPath>.couch.{compact, compact.data, compact.meta}`.
   
   ## Testing recommendations
   
   ## Related Issues or Pull Requests
   
   Add smoosh queue persistence: https://github.com/apache/couchdb/pull/3766
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] nickva commented on a diff in pull request #4099: Add filepath to is_compacting

Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4099:
URL: https://github.com/apache/couchdb/pull/4099#discussion_r918322735


##########
src/couch/src/couch_bt_engine.erl:
##########
@@ -141,10 +141,10 @@ delete_compaction_files(RootDir, FilePath, DelOpts) ->
         [".compact", ".compact.data", ".compact.meta"]
     ).
 
-is_compacting(DbName) ->
+is_compacting(FilePath) ->

Review Comment:
   As an extra precaution to emphasize this is a file path and not a binary dbname, let's assert that `FilePath` is a non-empty list `[_ | _] = FilePath`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] noahshaw11 commented on pull request #4099: Fix bugs in smoosh

Posted by GitBox <gi...@apache.org>.
noahshaw11 commented on PR #4099:
URL: https://github.com/apache/couchdb/pull/4099#issuecomment-1182551105

   Closing this in favor of https://github.com/apache/couchdb/pull/4100 since the scope of the PR has changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [couchdb] noahshaw11 closed pull request #4099: Fix bugs in smoosh

Posted by GitBox <gi...@apache.org>.
noahshaw11 closed pull request #4099: Fix bugs in smoosh
URL: https://github.com/apache/couchdb/pull/4099


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org