Re: [PR] HADOOP-19093. [ABFS] ILoadTestRenameRecovery [hadoop]

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #6596:
URL: https://github.com/apache/hadoop/pull/6596#discussion_r1514542657


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/TaskPool.java:
##########
@@ -545,7 +545,8 @@ private void resetStatisticsContext() {
    * @param futures futures.
    * @param sleepInterval Interval in milliseconds to await completion.
    */
-  private static void waitFor(Collection<Future<?>> futures, int sleepInterval) {
+  @InterfaceAudience.Private
+  public static void waitFor(Collection<Future<?>> futures, int sleepInterval) {

Review Comment:
   or move to FutureIO and cross reference from here. The cleaner solution



##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java:
##########
@@ -489,6 +489,7 @@ protected Path getUniquePath(String filepath) {
         .right(UUID.randomUUID().toString(), SHORTENED_GUID_LEN));
   }
 
+

Review Comment:
   cut



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org